This is just a passing thought, but I've just seen (another example of) someone re-testing a patch that is marked as committed and the issue closed. I'm not at all sure why people do this. Perhaps it's 'big red button' syndrome - they just can't help it!

I don't know how stretched the testing infrastructure is, but I would suggest to protect it from this sort of stupidity by preventing the re-testing of any patches attached to issues prior to one marking the thread as closed (for whatever reason). No one has any business testing a patch on a closed (fixed) issue, and it would be entirely reasonable to say if you re-open a task then you should supply a new patch for testing as, by definition, you accept the original patch is not doing it for you.

So that's all really. Not so much a feature request, as a feature suggestion. Don't allow the re-testing of patches in an issue that has been closed unless that issue is re-opened - and then only patches submitted since re-opening.

What do you think?

Comments

jthorson’s picture

jthorson commented
Project: Test driven development infrastructure » Drupal.org Testbots

Moving over from abandoned testing infra queue.

Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
commented
Project: Drupal.org Testbots » DrupalCI: Drupal.org Testing Infrastructure
Issue summary: View changes
Status: Active » Closed (outdated)

Marking this as outdated. I havent seen this to be a problem in the last couple of years, so we probably dont need to worry about it too much. Still moving it to the drupalci queue in case it does come up again.