Hi,

In template.php (line 31), if theme_get_setting('fast_tasks') returns FALSE then a variable that exists in page.tpl.php is undefined.

I changed 

if (theme_get_setting('fast_tasks')) {
  $vars['fast_tasks'] = _polpo_fast_tasks(); 
}

to:

$vars['fast_tasks'] = theme_get_setting('fast_tasks') ? _polpo_fast_tasks() : FALSE;

and that fixed it.

R

CommentFileSizeAuthor
#3 remove_fast_tasks-964998-3.patch5.21 KBAnonymous (not verified)

Comments

jptaranto’s picture

jptaranto
Primary language English
Location Sydney
commented
Assigned: Unassigned » jptaranto
Status: Active » Fixed

Hey rimian, I just removed the fast tasks altogether as they weren't particularly well implemented (no reliance on permissions being the biggest issue). There are better things out there that do that kind of stuff nowadays anyway.

Anonymous’s picture

Anonymous (not verified) commented
Title: Undefined variable $fast_tasks » Remove fast tasks
Version: 6.x-1.1 » 7.x-1.x-dev
Category: bug » task
Status: Fixed » Patch (to be ported)

Be good to do this to 7.x too...

Anonymous’s picture

Anonymous (not verified) commented
Assigned: jptaranto » Unassigned
Status: Patch (to be ported) » Needs review
StatusFileSize
new remove_fast_tasks-964998-3.patch5.21 KB

Here's a patch that fully removes fast tasks from 7.x.

jptaranto’s picture

jptaranto
Primary language English
Location Sydney
commented
Status: Needs review » Fixed

Thanks again for the patch! Done and dusted in the latest 7.x-1.x-dev.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.