Closed (fixed)
Project:
Mailchimp
Version:
6.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
8 Nov 2010 at 02:40 UTC
Updated:
21 Dec 2010 at 23:10 UTC
Jump to comment: Most recent file
The 'mailchimp_lists' variable gets double-serialized, can it just be single-serialized? In Drupal 6 any arrays that are saved with variable_set() are automatically serialized, so the following lines could be changed:
in mailchimp.module, from:
$lists = unserialize(variable_get('mailchimp_lists', array()));
to:
$lists = variable_get('mailchimp_lists', array());
remove:
$all_lists = unserialize($all_lists);
from:
$data = variable_get('mailchimp_lists', NULL);
$lists = array();
if (!empty($data)) {
$lists = unserialize($data);
to:
$lists = variable_get('mailchimp_lists', array());
if (!is_array($lists)) {
$lists = array();
}
if (!empty($data)) {
in mailchimp.admin.inc, from:
$saved_list = unserialize(variable_get('mailchimp_lists', NULL));
to:
$saved_list = variable_get('mailchimp_lists', NULL);
from:
variable_set('mailchimp_lists', serialize($lists));
to:
variable_set('mailchimp_lists', $lists);
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | mailchimp-n965088.patch | 4.05 KB | damienmckenna |
Comments
Comment #1
damienmckennaHere you go.
Comment #2
levelos commentedThanks for the patch, all set. http://drupal.org/cvs?commit=460970