Closed (fixed)
Project:
Version Control API -- Git backend
Version:
6.x-2.x-dev
Component:
Code
Priority:
Critical
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
8 Nov 2010 at 21:13 UTC
Updated:
26 Mar 2014 at 15:02 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
marvil07 commentedthis is a starter patch far from been completed that:
Comment #2
marvil07 commentedI found a dependency: #972058: Complete removing of {versioncontrol_operation_items} table
Comment #3
marvil07 commentedAnother patch, with more stuff, but still needs work and depend on the other issue too.
Comment #4
sdboyer commentedTook your patches and made some additions, changes, and ensured that it worked with #879858: Unify entity C(R)UD . So, well, we've got an incremental commit, anyway (http://drupal.org/cvs?commit=453332). But there's more to do. So marking needs work.
Comment #5
eliza411 commentedTagging for git sprint 5. Marco will commit when he's satisfied, without review, and this issue can be closed. Any problems will be opened as discreet issues.
Comment #6
marvil07 commentedThis is taking more than I expected.
So I am attaching the new things until now(some more work on local but not really ready to go out :-p):
Comment #7
marvil07 commentedA new update with the parser actually working :-), but still needs minor tweaks to avoid some unnecessary database interaction.
BTW: I committed some stuff to versioncotrol module to actually get to this point: http://drupal.org/cvs?commit=456280
What is new in this patch:
Comment #8
marvil07 commentedI removed several lines no more needed :-) (less inserts/updates on nested CRUD), but actually to let this work, I am also depending on #983202: Stop passing the same $options parameter in cascade on operation and item entity CRUD methods..
Ok, finally I think this is ready to be reviewed!
So, waiting for sdboyer opinion before committing it.
Comment #9
sdboyer commentedI thought you were just going to commit this and we'd solve problems as they came up?
Comment #10
marvil07 commentedSure :-), finally iscommittted \o/
I am changing the status, but probably we are going to need a follow up if there is something more.