gurayc [gurayc]

1. Please remove LICENSE.txt since code committed to contrib is automatically licensed as GPL V2
2. The following function can be removed since it accomplishes nothing:
   

   /**
    * Implementation of hook_menu().
    */
   function tckimlikno_menu() {
     return null;
   }
   

3. There are a few minor code style issues, though not enough that I would block this application. eg:
   

   /**
    * Theme function for 'showsome' tckimlikno field formatter.
    */
   function theme_tckimlikno_formatter_showsome($element) {
     return substr($element['#item']['tckimlikno'],0,5).'******';
   }
   

   (no spaces after commas in arguments in a few places)

setting to needs work.

Also titling in a more useful fashion.

Fixed means you got your CVS account. I think that's not the case here ;)

gurayc: Can you post your updated module w/ the fixes?

I should have mentioned this last review, but all your files also need an @file docblock. See http://drupal.org/node/1354#files

As far as I am concerned, once that is done, everything is in shape for a CVS account grant. Sorry for making you have to reroll your module once again!

Looks good to me.

Thanks for the work on this gurayc. I'm marking this RTBC; someone should be by fairly soon to grant the CVS access.

Approved based on brianV's RTBC.

Michelle

I am giving credits to the users who participated in this issue.