veeeb [veeeb]

veeb: Perhaps I might suggest uploading to an external server, or perhaps putting it on github so it can be accessed. I am not sure what the 'official' way of handling larger uploads for contrib modules is.

Just as a side note, contrib modules can only contain GPLV2 licensed code. If you module required third party libraries, the usual practice is to note this in the README.txt, and give a path where the libraries should be downloaded and placed for your module to find them. You can refer to the apachesolr and tinyMCE modules for examples of this.

I am setting to 'needs review' so that it comes to the attention of other CVS app reviewers who may know the usual process for modules that exceed the 1mb upload limit.

To add as a further reference:

3rd party libraries in Drupal CVS

Veeeb,

Thanks for posting that. I looked at what the veeeb editor does, and I really want to see this go into contrib!

A few points:

1. The .module file needs an @file docblock in the header: http://drupal.org/node/1354#files
2. Please remove the chunks of commented-out code in the .module file.
3. Please add docblocks documenting the veeeb_process_textarea() and veeeb_process_hidden() functions.
4. Please run your module through the Coder module code review process, and fix any code style flags it may raise. When that is done, please verify that your module complies with the Coding Standards.
5. Can you please explain how the bundled version of the Veeeb editor differs from the version available on the Veeeb website? I see the file is called veeebDrupalEditor.swf, so I assume it has been customized in some way.
6. Can you please include a README.txt that gives installation instructions, and information about the module?

Thanks for your effort so far. I can't wait to see this one go into contrib!

Hello, and thank you for applying for a CVS account. As per requirements, the motivation should include a comparison with the existing projects.

Thank you for your reply.

Hi veeb.

20 days is actually not all that bad for this queue. Perhaps once you have a CVS account, you would consider performing a few reviews to help get the queue down ;).

Anyways, I reviewed your module, leaving the editor alone since I am considering it an external library.

Can you please add an $Id$ tag to the README.txt file as well?

Also, please quickly review your inline comments - they should all start with a capital letter, and end with a period. There are only a few like this in the code.

Once that is done, I'll be able to RTBC this module. As I said above, I can't wait to see it in contrib!

Err, a few other items:

1. Can you please remove the Copyright and License information from README.txt? Any code submitted to CVS is released as GPLv2. Also, the copyright statement will no longer be valid once you accept your first patch ;).

2. Can you verify that you are releasing the editor and it's related media under the GPL? As I mentioned in post #2, only GPL-licensed code and files may be included in Drupal's CVS. Alternatively, if the editor can not be released under the GPL, please remove it from the module and include instructions in the README.txt that instruct the users where to download it so the module will find it! Perhaps you would consider using the Libraries API: http://drupal.org/project/libraries

Any files that are available from third-party sites should not be committed in drupal.org repository, independently from the license used for the files.
Having multiple copy of the files (which is what would happen if any modules would include a copy of the files in its own repository) causes problems, expecially if each module uses a different version that is executed at the same time. That is the reason users should be instructed to download the necessary files from the third-party site.

This is looking really good now.

There are a few extra blank lines in the .module file, but that is a minor issue. The only outstanding problem I can find is that it isn't documented in the README.txt about where to download and extract the veeeb editor.

Also, you might want to consider a hook_requirements() implementation to check to make sure the library is installed correctly, and provide a notice on the 'Status' report page if it is missing, or perhaps outdated.

Anyways, once the README.txt is updated, this should be ready.

Hi. Please read all the following and the links provided as this is very important information about your CVS Application:

Drupal.org has moved from CVS to Git! This is a very significant change for the Drupal community and for your application. Please read the following documentation on how this affects and benefits you and the application process:
Migrating from CVS Applications to (Git) Full Project Applications

• The status of this application will be put to "postponed" and by following the instructions in the above link, you will be able to reopen it.
• Or if your application has been "needs work" for more than 5 weeks, your application will be marked as "closed (won't fix)". You can still reopen it, by reading the instructions above.

As per previous comment, I am setting this issue as Won't fix.
Since new users can now create full projects, applications have a different purpose and they are handled on a different issue queue. See Apply for permission to opt into security advisory coverage for more information.