Notice: Undefined variable: element in _link_sanitize()

Mehhhh... Change it to;

// Some old field data may have $element['#item']['attributes']['rel'] as an array, which will cause errors:
  if (isset($element['#item']['attributes']['rel']) && is_array($element['#item']['attributes']['rel'])) {
    unset($element['#item']['attributes']['rel']);
  }

...Just in case...

Pobster

Actually, the problem is that $element is not defined in this function. It was probably meant to be:

// Some old field data may have $item['attributes']['rel'] as an array, which will cause errors:
if (is_array($item['attributes']['rel'])) {
  unset($item['attributes']['rel']);
}

This attached patch fixes the PHP notice.

Looks like #2 is a reverse patch or however you say that. Here is one that works for me:

Gets rid of the errors, and the logic seems sound to me. Can't verify it doesn't break old field data however.

Patch in #3 works for me, gets rid of the erros. Thanks everyone!

Any idea when this patch is going to make it into a release?

I've mostly been concentrating on getting link 7 ready, but I think I can spend some time this weekend going through the 2.9 bugs and seeing what patches can get applied so that at least the dev release holds the fix - after a week of reviews from folks on that, we could get a release soon before Drupalcon.

Well, the patch didn't work because the function had been moved into link.inc, but the change has been committed to cvs.

Hi,
I had this error too after migrate to Pressflow and this patch works for me ;)
Bye

Hi,

I'm getting this error in link 6.x-2.9 from 2010-Jun-14:

Notice: Undefined variable: element in _link_sanitize() (line 445 of /var/www/drupal/sites/all/modules/link/link.module).

Since this issue seems to have been fixed a while ago and the last release of 'link' was more than one year ago, could we please get a new stable release, including the fix?

Thank you!

pretty please

subscribe

patch in #3 worked..
thanx..

Confirming, patch from #3 seems to work.

#14, #15 - did you patched against latest dev or against 6.x-2.9 release ?

"git apply" against 6.x-2.9.

thx 4 info, asb!

I'm pretty sure the change for this got put into cvs then - git now - Digidog. I think the main thing is we don't have a release of 6.x-2.x branch in a long time.

That's why I'd made the ticket 'fixed' before.

Come on guys, this was reported in November 2010 and it's now June 2012 and there's no new release that fixes this! Please put out a release with this fix!

RTBC since October 24, 2011. Well, maintaining the 8.x-1.x-dev release (and preparing for 9.x-1.x-dev :) seems to be more important than maintaining that boring old stuff people are actually using in production.

Initialize $element['#item']['attributes']['rel'] = ''; pre line 445 .Version 6.2.9

Reminding myself of this.