Download & Extend

Cannot use tokens for sender and recipient in Rules actions

Project:Mime Mail
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

So if I use a CCK field token for sender or recipient it should work, right? Because if I use a token in one of those fields I get this:

Please enter a valid e-mail address for recipient.

This issue moved from #501722: HTML mail actions for Rules

Comments

#1

Status:active» needs review

Please try the attached patch.

AttachmentSize
mimemail.966514_01.patch 2.76 KB

#2

When got this mimemail_rules_action_mail_validate() introduced?
Because of tokens and php evaluation we moved all validation to mimemail_rules_form_settings_process(). What about validating emails there? In this state php evaluation and tokens should be applied.

@patch
Don't forget that also php evaluation should be supported.

#3

Holy... You're right. I moved this segment here from the Drupal action form, but I see I shouldn't have. I guess it will be just simply removed.

AttachmentSize
mimemail.966514_02.patch 1.99 KB

#4

Sorry, I don't follow what you're saying above. If I want to use tokens for sender and receiver do I apply the patch in #3? And are there any side-effects?

#5

The patch removes the validation. The only side-effect is that you can enter an invalid e-mail address in the form, but I think in the most cases you will use tokens and PHP evaluation, so the validation is needless. Note that Rules actions doesn't use this kind of validation by default.

#6

OK, sorry for the delay, but the patch applies just fine and it seems to work. Thanks!

#7

Status:needs review» fixed

Committed to DRUPAL-6--1 branch, will be available in the development snapshot soon. Sorry for the inconvenience fellas.

#8

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.