Hi,

Gabor Horvath enhanced the current version of PT for a client of us - maybe some people want to test ... and maybe the maintainer wants to start a new version from this point ...

- Some new fields are included (profession, institution, url)
- Theming: hide signature tab
- Role initial signer - you can give this role in the signatures administration
- Some Blocks are generated: Lastx Signatures, all signatures, initial signers
- Install scheme is up to date
- Edit signatures

sb

CommentFileSizeAuthor
#13 petition_node_modified.tar_.gz52.61 KBsachbearbeiter
#12 petition_node_modified.tar_.gz52.56 KBsachbearbeiter
#8 petition_confirm.patch10.65 KBcolmobri
petition_node_modified.tar_.gz52.12 KBsachbearbeiter

Comments

vako’s picture

vako commented

I will be testing this soon. Thank you!

jonask123’s picture

jonask123 commented

WORKS FINE!
Now testing multilanguage options.

Thanks!

jonask123’s picture

jonask123 commented

After mail confirmation users can't see any message that: "your mail confirmation was successful..." and that everything is fine.
They just see the signature list and just all. Some of them are very confused...

Is there any possibilities to do that?

colmobri’s picture

colmobri commented

I've installed the module and it works well too. Many thanks!

@jonask123, did you find a solution? I've modified the code so that signatures are ordered descending instead of ascending by position. So the signature at the top should be the last person to sign. That should reduce confusion.

jonask123’s picture

jonask123 commented

@colmobri no, I wasn't find any solution. Your idea is very good! Could you write what and how you modify?

colmobri’s picture

colmobri commented

Sorry for the delay replying - I didn't seem to get a notification. Actually, I've discovered the module tries to put up a message thanking the person for signing but there was a small bug preventing the message from appearing. I also added a couple of lines to give a message if the signature has been confirmed already or if the signature can't be found (if deleted after the expiry period).

Are you familiar with patches?

jonask123’s picture

jonask123 commented

@ colombri Could you please send o put somewhere this patch? O write a code wich we should change to fix that bug?

colmobri’s picture

colmobri commented
StatusFileSize
new petition_confirm.patch10.65 KB

@jonask123

Here's the patch to fix the confirm signature bug and adds some other error checking and messages.

Also changes the default sort order to descending which seems to give more intuitive results and fixes a small bug with that.

markdavidzahn’s picture

markdavidzahn commented

I tried this and like it, but it's not putting proper numbers on the signatures. They're all zero.

sachbearbeiter’s picture

sachbearbeiter commented

maybe we will include patch of #8 in the next weeks and put back a complete project file + we will also test, if we can reproduce #9 ...

leahmd’s picture

leahmd commented

subscribing

sachbearbeiter’s picture

sachbearbeiter commented
StatusFileSize
new petition_node_modified.tar_.gz52.56 KB

"Updated version is attached.

Modifications:
- added patch of #8 that fixes the confirm signature bug and adds some
other error checking and messages.
- the position numbering seems to be good, more info is needed if
someone has still problems with it.
- modified second parameter of petition_signature_form() because
otherwise received the following message
warning: Parameter 2 to petition_signature_form() expected to be a
reference, value given in includes/form.inc on line 378."

:)

sachbearbeiter’s picture

sachbearbeiter commented
StatusFileSize
new petition_node_modified.tar_.gz52.61 KB

"Updated version is attached.

Modifications:

- Added 'position' to the node edit page at Petition settings /
Advanced petition settings / Fields displayed in the signature
overview. Default is off. If it is switched on, the position is
displayed on the signature page, and the default sorting mode of the
'position' field is descending, while the the default sorting mode of
the other fields is still ascending.
- Download the result as a CSV: removed the first column, because it
was always empty."

ideanator’s picture

ideanator commented

Seems like this is the module I need for petition, what do I have to do, so it can be used for Drupal 7. I am using drupal 7.
Thanks

galooph’s picture

galooph commented

Thanks sachbearbeiter!

I've taken over ownership of this module and I've just started a new 6.x-2.x dev branch based on your enhanced version. Myself and mcjim hope to get a D7 version out soon too.

sachbearbeiter’s picture

sachbearbeiter commented

#15 wonderful :)

vako’s picture

vako commented

@galooph & mcjim, thank you for your taking initiative and hopefully we can have an even better Drupal module!

galooph’s picture

galooph commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

chiappa’s picture

chiappa commented

Anyone hacked a Drupal 7 version yet?