When using "System generated ID" option in the CCK match, pimport doesn't correctly find/use the node ID in the CSV.

CommentFileSizeAuthor
#1 pimport-966588.patch2.1 KB345665436533456

Comments

345665436533456’s picture

345665436533456 commented
StatusFileSize
new pimport-966588.patch2.1 KB

Patch which may help attached. But I've not tested it.

Patch includes comment:
what does it mean if you can't load a node by unique ID at this point - should it be an error?

marcus_clements’s picture

marcus_clements commented

Looks good to me although I haven't tested it either. There is still work to be done on error handling but I'd say that it should throw an error. If we were matching against an arbitrary unique id there would be an argument for creating a new node at this point, but since we're checking against a nid then presumably this means something has gone wrong.

marcus_clements’s picture

marcus_clements commented
Assigned: Unassigned » marcus_clements
Status: Active » Needs review

I've taken your patch and reworked it slightly - comitted in the 6.x-1.x branch.

marcus_clements’s picture

marcus_clements commented
Status: Needs review » Closed (fixed)