Allow grabbing multiple images [#967658]

I have a custom Feedds parser which returns the direct URLs to one or more images. In order to store those images in an imagefield, I'm using Imagegrabber with the direct-image-url patch from #858430: Proposal - add feature to allow download of image URL directly - skip the scraping step.

The patch attached here builds on that patched version of 6.x-1.0, adding the possibility to insert multiple images from an array with image URLs (or multiple images scraped from a page), provided that the CCK imagefield is set to multiple values.

At this point, importing multiple images does not work when 'Feeling lucky' is set to 'Yes', because that setting causes the image scraper to return only a single image. Maybe the 'Feeling lucky' setting should be rewritten to 'Sort' setting ('sort by order of appearance' or 'sort by image size'), leaving the limitation of the number of imported images up to the CCK field settings.

Feedback is very welcome!

Comment	File	Size	Author
#1	feeds_imagegrabber.module.txt	29.05 KB	marcvangend
	feeds_imagegrabber-multiple-values.patch	4.95 KB	marcvangend

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

marcvangend

he/him

Dutch

Amsterdam

CreditAttribution: marcvangend commented 10 November 2010 at 12:52

File	Size
feeds_imagegrabber.module.txt	29.05 KB

For anyone who doesn't want to be bothered with applying patch upon patch, here is the .module file as I currently use it.

Comment #2

TomMynd CreditAttribution: TomMynd commented 3 December 2010 at 15:13

Hi,

I tested your patch and it worked for me right out of the box. Thank you for this enhancement.

I wonder, when this will be added to the dev-Version. I think this would be a must have feature for this module.

Best regards, Tom

Comment #3

marcvangend

he/him

Dutch

Amsterdam

CreditAttribution: marcvangend commented 3 December 2010 at 16:19

Hi Tom,
Thanks for testing and for your feedback. I also hope that these patches will be added to the module, but we will have to wait for the maintainer to review them. Meanwhile, if you find bugs, usability issues or other aspects that can be improved, please let me know. If the patch here is good and well-tested, it will have a better chance of being committed.

Comment #4

TomMynd CreditAttribution: TomMynd commented 3 December 2010 at 20:38

Hi,

currently I have found no bugs or anything else. It worked for me out of the box.

If I find something that looks like a bug I will report it here. I have to do some more testing.

have fun,

bye!tom

Comment #5

EndEd CreditAttribution: EndEd commented 4 March 2011 at 08:37

Works Perfect

Comment #6

tfranz CreditAttribution: tfranz commented 29 March 2011 at 10:27

Works fine - thank you!
Should be imho committed ...

Comment #8

publicmind CreditAttribution: publicmind commented 31 July 2011 at 08:44

Version:	6.x-1.0	» 7.x-1.x-dev
Status:	Needs review	» Fixed

fixed in the latest release of the FIG for D7. I have although intentionally left out the 'direct' image mapping which is supported by Feeds out-of-the-box now.

Regards,