Download & Extend

Missing profile.module check causes failed queries

Project:Bakery Single Sign-On System
Version:6.x-2.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:patch (to be ported)

Issue Summary

In _bakery_register_submit() there is no checking if "profile" module exists like it's in bakery_settings().

Comments

#1

Can you specify what kinds of problems that causes?

#2

It can result to SQL error "Table profile_fields doesn't exist query: SELECT name FROM profile_fields WHERE register = 1..."

#3

Marked #971252: profile table database error as a duplicate.

#4

Status:active» needs review

Something like this?

AttachmentSize
967682_profile_bakery_register_submit.patch 1.38 KB

#5

Status:needs review» reviewed & tested by the community

I was able to test this by registering on a subsite. Without the patch we get the message:"User warning: Table 'sd6.profile_fields' doesn't exist query: SELECT name FROM profile_fields WHERE register = 1 in _db_query() (line 141 of /home/greggles/workspace/d6/includes/database.mysqli.inc)."

With the patch no error message about a missing table. I tested that the functionality still works as expected with editing a profile field on master and getting updated on slave and it does.

I plan to commit this shortly but leave it RTBC for others to provide input.

#6

The same error pops up all the time on localize.drupal.org. #971252: profile table database error was submitted based on that (and was marked duplicate). Please commit, so we can roll it out on l.d.o as well.

#7

Title:Missing "profile" check» Missing profile.module check causes failed queries
Status:reviewed & tested by the community» patch (to be ported)

Now committed - http://drupal.org/cvs?commit=460026

#8

Thanks, rolled out on localize.drupal.org with other Drupal 6.x-2.x changes with the alpha2.

nobody click here