There is typo that leads to non gathering arguments passed to REST call as GET variables. Please review the patch.

To reproduce the bug: create the resource with argument with source 'params' (according to services.services.api.php). Try to make the call and pass the argument.

CommentFileSizeAuthor
#7 services-967786.patch1.08 KBkylebrowning
#5 services-get-arguments-rollback.patch2.55 KBygerasimov
services-rest_server-params.patch790 bytesygerasimov

Comments

kylebrowning’s picture

kylebrowning commented
Status: Active » Needs review

Set to needs review for testing.

kylebrowning’s picture

kylebrowning commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

polarbear128’s picture

polarbear128 commented
Status: Closed (fixed) » Active

Reopening this as this is a patch that introduced a bug.

See http://drupal.org/node/1010082

The root cause is that services.services.api.php has a typo in the comments for usage (Advises use of params, when it should be param). This caused patch submitter to create a module with incorrect argument, and when it didn't work, to submit a patch that fixes the bug in their module, but causes it in the "core" Services modules.

Patch needs rolled back and documentation in services.services.api.php needs amended for typo.

Cheers

ygerasimov’s picture

ygerasimov commented
Status: Active » Needs review
StatusFileSize
new services-get-arguments-rollback.patch2.55 KB

polarbear128 is right. If we look at implementation of standard user resource (index method), the key is 'param' and not 'params'. Please rollback.

gdd’s picture

gdd
he/him
Primary language English
Location Portland, OR
commented

This has been committed to 7.x, will get to the 6.x issues after I get that release tagged.

kylebrowning’s picture

kylebrowning commented
StatusFileSize
new services-967786.patch1.08 KB

Please review 6.x patch

kylebrowning’s picture

kylebrowning commented
Status: Needs review » Fixed

fixed and commited for 6.x

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.