Hi, I'm quite familiar with working with the sermepa systems but I'm finding the "Add a bank" form to be a bit confusing.

I like the fact that (in some places) you have used the bank terminology for the field names (Ds_Merchant_MerchantCode) however I have 2 issues.

What am I supposed to put for Ds_MerchantSignature? Its a bit confusing seen as Ds_Merchant_MerchantSignature exists and that is a calculated field, not fixed. By looking through the code, it appears that you should put the "clave" value here however what do I then put in the codename for the bank? I think some explanation and some example values would be really useful here.

The other issue that I have is that the language field is missing.

Thanks
Will Eaton

Comments

willeaton’s picture

willeaton commented

p.s. can't you auto generate a unique bank id so that you don't confuse the user? It wasn't very obvious to me what it was for however I am techy savvy and was able to work out what you meant by it.

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented

Ds_Merchant_MerchantSignature is how la caixa calls or used to call to the signature, password, clave, etc field provided by the bank, is not a calculated field, is the signature provided that you need to generate the sha to get the authorization in the payment process. Being this a module that fits several banks that normally call these fields different from each other, I had to choose one.

Bank id is required for exporting/importing feature, it's a very common option now in drupal (you will see it in modules like features, boxes, you need a machine name for exporting config)

Anyway, patches for all these things you point are very welcome. If you don't feel like changing the autogeneration of the bank id, I'm sure that the documentation and naming of the fields can get much improved.

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented
Status: Active » Needs work

If someone wants to improve the naming and the configuration workflow is warm welcome to.

massimoi’s picture

massimoi commented

I agree... as a non expert of the spanish system, its very complex to fill in the form!

Thanks
Massimo

turtulino’s picture

turtulino commented
Version: 6.x-2.1 » 6.x-3.x-dev
Assigned: Unassigned » turtulino
Issue summary: View changes
Status: Needs work » Fixed

  • turtulino committed e3141a7 on 
    #967896 Added some descriptions from Redsys manual

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.