"Translation for [title] is complete. You can review the [title] and make sure it is correct."

comes from:

165:      drupal_set_message($message = t('Translation for !title is complete. You can review the !link and make sure it is correct.', array('!title' => strip_tags($txt), '!link' => $txt)));

Several things wrong with this:

- 'the title' is wrong. Do you mean something like 'the [content type]'?
- the link is wrong. In my case it was given as "/?q=node/2" which is not only wrong because I have clean URLs enabled, but also wrong because my Drupal is in a subfolder. Use url() to form correct paths.
- strip_tags() is probably the wrong function to use here.

Comments

brucepearson’s picture

brucepearson commented
Status: Active » Fixed

Thanks for the report.

I've changed it so that it uses url() to get the correct link and also removed the strip_tags() as it's not really needed.

joachim’s picture

joachim commented

Thanks!

Though what I meant about strip_tags is that it's probably check_plain() you need on node titles -- you still need some sort of cleaning up ;)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

joachim’s picture

joachim commented
Status: Closed (fixed) » Active

Reopen -- AFAIK some sort of sanitizing is still needed here.

icanlocalize’s picture

icanlocalize commented
Status: Active » Postponed (maintainer needs more info)

Want to propose a patch?

brucepearson’s picture

brucepearson commented
Status: Postponed (maintainer needs more info) » Fixed

check_plain now used for processing the title text.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.