Hi,
Just stumbled across this. The following path should be updated in this module's implementation of HOOK_HELP:

case 'admin/settings/upload'
should be...
case 'admin/settings/uploads'

With this amendment the help text appears.

CommentFileSizeAuthor
#2 969252-upload-help-path-D6.patch2.49 KBdave reid
#1 969252-upload-help-path-D6.patch2.46 KBdave reid

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Needs review
StatusFileSize
new 969252-upload-help-path-D6.patch2.46 KB

That's pretty funny that we haven't noticed that for so long. Patch for review against 6.x-1.x-dev.

For an additional lol, we were linking to the admin/settings/types page, which was moved to admin/content/types in D6...

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Version: 6.19 » 6.x-dev
StatusFileSize
new 969252-upload-help-path-D6.patch2.49 KB

We should also link to the upload section in the permissions page rather than making the user scroll. This does not change any translation strings.

sivaji_ganesh_jojodae’s picture

sivaji_ganesh_jojodae commented
Status: Needs review » Reviewed & tested by the community

Patch #2 looks good, applies cleanly and really no brainier. Marking RTBC.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Fixed

Looks good, thanks, committed. Drupal 7 has no upload.module so not applicable there.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.