sf_webform Abandoned/Outdated? Alternative available as sandbox project

Both patches fail for me against the latest(lol...) dev - would you mind packaging up your version for comparison?

Let me correct that - If I first use your patch from the other topic - the first patch above works great - however this second patch fails completely for me. And This "Added support for mapping keys OR labels for "select" webform components, instead of just keys. " Is very critical for me because we can't tell which webform value is being passed to prematch.

@aaronbauman: Posting the new version as a tar.gz in here might be the best idea for now...

@aaronbauman I for one, am very grateful. Thank you!

I spent some time working on this today, and I think I've got this module back in working order with the latest release of the salesforce module.

Diff:

85,86c85
< 
<     if ($map->fields && preg_match('/^node_webform_(\d+)$/', $map->drupal, $matches)) {
---
>     if (!empty($map['fields']) && preg_match('/^node_webform_(\d+)$/', $map['drupal'], $matches)) {
98c97
<         '#value' => t('This fieldmap is associated with webform node %title (nid %nid) - !link', array("%title" => $webform_node->title, "%nid" => $webform_node->nid, '!link' => l("edit", SALESFORCE_PATH_FIELDMAPS ."/".  $map->fieldmap ."/webform", $options = array("query" => "edit=1&destination=". SALESFORCE_PATH_FIELDMAPS ."/". $map->fieldmap ."/edit"))))
---
>         '#value' => t('This fieldmap is associated with webform node %title (nid %nid) - !link', array("%title" => $webform_node->title, "%nid" => $webform_node->nid, '!link' => l("edit", SALESFORCE_PATH_FIELDMAPS ."/".  $map['fieldmap'] ."/webform", $options = array("query" => "edit=1&destination=". SALESFORCE_PATH_FIELDMAPS ."/". $map['fieldmap'] ."/edit"))))
210c209
<     if ($access && $exported && !$salesforce_submission->sfid) {
---
>     if ($access && $exported && empty($salesforce_submission['sfid'])) {
218,219c217,218
<       if (!$salesforce_submission->sfid && $salesforce_submission->sfid == 0) $submissions[$submission->sid] = '';
<       if (!$show_all && $salesforce_submission->sfid) continue;
---
>       if (empty($salesforce_submission['sfid']) && $salesforce_submission['sfid'] == 0) $submissions[$submission->sid] = '';
>       if (!$show_all && $salesforce_submission['sfid']) continue;
305,306c304,305
< 		
<       if ($access && $exported && !$salesforce_submission->sfid) {
---
> 
>       if ($access && $exported && empty($salesforce_submission['sfid'])) {
314,315c313,314
<         if (!$salesforce_submission->sfid && $salesforce_submission->sfid == 0) $submissions[$submission->sid] = '';
<         if ($salesforce_submission->sfid) continue;
---
>         if (empty($salesforce_submission['sfid']) && $salesforce_submission['sfid'] == 0) $submissions[$submission->sid] = '';
>         if ($salesforce_submission['sfid']) continue;
616c615
<   $map->fields = array();
---
>   $map['fields'] = array();
620c619
<   _sf_webform_set_webform_index($form_state['values']['webform_nid'], $map->fieldmap, $form_state['values']['login_status']);
---
>   _sf_webform_set_webform_index($form_state['values']['webform_nid'], $map['fieldmap'], $form_state['values']['login_status']);
622c621
<   $form_state['redirect'] = SALESFORCE_PATH_FIELDMAPS .'/'. $map->fieldmap .'/edit';
---
>   $form_state['redirect'] = SALESFORCE_PATH_FIELDMAPS .'/'. $map['fieldmap'] .'/edit';
698c697
<     if ($uid_key = array_search(SALESFORCE_WEBFORM_FIELD_UID, $map->fields)) {
---
>     if ($uid_key = array_search(SALESFORCE_WEBFORM_FIELD_UID, $map['fields'])) {
703c702
<     if ($sfid_key = array_search(SALESFORCE_WEBFORM_FIELD_SFID, $map->fields)) {
---
>     if ($sfid_key = array_search(SALESFORCE_WEBFORM_FIELD_SFID, $map['fields'])) {
714c713
<     if ($uid_key = array_search(SALESFORCE_WEBFORM_FIELD_UID, $map->fields)) {
---
>     if ($uid_key = array_search(SALESFORCE_WEBFORM_FIELD_UID, $map['fields'])) {
719c718
<     if ($sfid_key = array_search(SALESFORCE_WEBFORM_FIELD_SFID, $map->fields)) {
---
>     if ($sfid_key = array_search(SALESFORCE_WEBFORM_FIELD_SFID, $map['fields'])) {
738c737
<       $response = $sf->client->create(array($object), $map->salesforce);
---
>       $response = $sf->client->create(array($object), $map['salesforce']);
742c741
<       watchdog(SALESFORCE_LOG_SOME, 'Could not export webform submission with: %error.', array("%error" => $e->faultstring), WATCHDOG_ERROR);
---
>       $sf->watchdog(SALESFORCE_LOG_SOME, 'Could not export webform submission with: %error.', array("%error" => $e->faultstring), WATCHDOG_ERROR);
753c752
<     $response = $sf->client->update(array($object), $map->salesforce);
---
>     $response = $sf->client->update(array($object), $map['salesforce']);
869c868
<   foreach ($fieldmap->fields as $component => $form_key)  {
---
>   foreach ($fieldmap['fields'] as $component => $form_key)  {
1029c1028
<         if ($salesforce_submission->sfid) continue;
---
>         if ($salesforce_submission['sfid']) continue;

Subscribing

@stella/openbook:

Do either of you have the time to look at this patch and commit?

If not, would you be open to having a co-maintainer who could proceed with this, either in the same 6.x branch or in a 6.x-2.x branch?

@aaronbauman: I would be strongly opposed to adding it to the core suite. I think the suite should only contain the bare minimum of modules needed to connect with Salesforce, make fieldmaps, queueing, etc. I would actually argue that it should be smaller than it is.

If the maintainers aren't responding to this issue, then I would rather go through the Abandoned Projects process, and get maintainership of this module.

For now, I've put the code from #9 into a sandbox: http://drupal.org/sandbox/evandonovan/1198324.

I plan on working with it some in the next few weeks, since Salesforce/Webform integration is a requirement for a current project I'm working on. Eventually, I would hope to deprecate the sandbox in favor of getting the code back into the main module.

subscribing

@joeybaker: Does the module still work for you using the code that you posted? In my development site, it doesn't actually export to Salesforce, nor does the Salesforce Export tab indicate that there is data to be exported to Salesforce. I will have to look into this further.

Evan, I'm very interested in this as I'm currently forced to use nodes for Salesforce-synched event bookings on one of my clients' sites. I'm not familiar with this code but am happy to have a look at the sandbox if it helps. Are you planning a second commit soon?

My sandbox version of this code should work again now, although I haven't tested everything yet, just the manual export. It was a beast to fix it for compatibility with the latest API of the Salesforce module for 6.x. Any testing is welcome. You can also use the issue queue there to report bugs, etc., and I'll make an update into this issue later.

For anyone else subscribing, the link again is http://drupal.org/sandbox/evandonovan/1198324. You will need to git clone in order to get the code - Drupal.org doesn't package sandboxes.

Subscribing. Also, just a note regarding the point about git clone being the only option on sandbox projects. I think you can still share a tar.gz via the "snapshot" links provided in the repository viewer, e.g.:

http://drupalcode.org/sandbox/evandonovan/1198324.git/snapshot/80da2fc4b...

I just altered the title a bit to make it easier for new users to find the working version of this code. Unless you have not upgraded the Salesforce API or webform in over a year, this project's version simply will not work.

Please try the 6.x-1.x branch in the sandbox at: http://drupal.org/sandbox/evandonovan/1198324

Of course there is some debate about where this project should ultimately live, etc, but in the meantime I'm just hoping others who may now need this functionality in D6 can benefit from our recent attempts to support a working version elsewhere. In fact, I just committed a barrage of new updates to the sandbox project linked above in the last couple weeks (see the commit history for more). So I just wanted to point out that this code has seen some attention recently.

I too am happy to bring this repository up-to-date with what's in the sandbox (independent of the ongoing discussion about the final home for webform support, as a resolution to that may be some time coming). I am probably the one who has been working with this D6 code most recently and am happy to segment and push updates here that I have already applied to the sandbox, etc...