Closed (fixed)
Project:
Publication Date
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
11 Nov 2010 at 22:16 UTC
Updated:
7 Jun 2014 at 21:59 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
tahiche commentedThanks math0ne !!
Comment #2
chrislabeard commentedI tried to run this patch and got this error.
Comment #3
cesareaugusto commentedWould it be possible to port this pacth to the D7 version? :)
Comment #4
dgtlmoon commentedbetter formed patch attached
Comment #5
markie commentedHi,
I modified the patch above for a D7 db_query().
enjoy
Comment #7
simeRerolled the patch in #5 minus the dsm()
Changing the issue version to 7.x (so that maybe the bot will succeed).
Comment #8
simeComment #9
simeOh, I totally got the node ID wrong on my patch file name, soz about that.
Comment #10
dgtlmoon commentedI see
Notice: Trying to get property of non-object in publication_date_form_alter() (line 124 of modules/contrib/publication_date/publication_date.module).
Comment #11
dgtlmoon commentedRemoved dsm from sime and form warning when adding a node (no $node->published_at) was present
Comment #12
simeSorry @dgtlmoon, i thought i got rid of that!
Comment #13
dgtlmoon commented@sime: its ok, but im scared that you're using die(), you use a breakpoint debugger right? :)
Comment #14
cesareaugusto commentedWill it be merged into the main release?
Comment #15
dgtlmoon commented@cesareaugusto yeah, can you test that patch for us?
Comment #16
cesareaugusto commentedSure I can! Though I don't know how to apply patches. Could it be merged into the downloadable dev release?
Comment #17
dgtlmoon commentedyoull have to learn how to apply the patch, sorry
Comment #18
dgtlmoon commentedAnother patch, $node->published_at is always set, and thus it can be (bool)false, only set the #default_value if it is not false
Comment #19
wickwood commentedThe patch in #18 is useful, but it throws this error when creating a new node:
Notice: Trying to get property of non-object in publication_date_form_alter() (line 126 of /path-to-site/sites/all/modules/publication_date/publication_date.module).Comment #20
wickwood commentedI think the problem that I reported in #19 is due to the fact that the $node object does not exist.
I fixed line 126 by changing it from:
if ($node->published_at) {to
if ($node && $node->published_at) {Sorry I don't have patch for you.
Steve
Comment #21
tobyontour commentedI had a look at the patch and it didn't work with new nodes (only updates). I modified it a bit and recreated it to use the node form rather than hitting every form.
Comment #23
tobyontour commentedI'm an idiot. This one should work.
Comment #24
tobyontour commentedComment #25
dgtlmoon commentedhmm nope, above patch still causes an error when the field is left blank
Comment #26
dgtlmoon commentedComment #27
tobyontour commentedI'm not getting an error. What error is it giving?
Comment #28
dgtlmoon commentedTry this patch, it add's significant testing and a slight refactor of the save process
Comment #29
dgtlmoon commentedwoops
Comment #30
soulston commentedNo errors here :)
Comment #31
klokie commentedFYI the patch in #4 worked for me (D6). Thanks!
Comment #32
Grayside commented#29 works in OpenPublish.
Comment #33
elmertoft commentedPatch in #29 works for me on latest D7 :)
Comment #34
dgtlmoon commentedGreat, committed to 7.x-1.x, thanks for the reviews!
Comment #35
elmertoft commentedThanks Leigh. Keep up the good work! :)
Comment #36
dgtlmoon commentedha, hey Andreas :)