Closed (fixed)
Project:
HTML Purifier
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
12 Nov 2010 at 09:47 UTC
Updated:
26 Nov 2010 at 14:10 UTC
Was reviewing your changes for a Drupal Gardens code update. We'll use the 7--1 branch and not the forked (Drupal 6) HEAD that we did before. Looking at changes on the branch however, it looks like you have elaborate checking of PHP versions. You try to ensure at two places that at least PHP 5.0.0 is used. Drupal 7 will not run with anything but PHP 5.2.4+ so checking this in Drupal 7 is futile and extra code that you can easily get rid of.
Here is a simple patch.
| Comment | File | Size | Author |
|---|---|---|---|
| remove-php5-checking.patch | 2.08 KB | gábor hojtsy |
Comments
Comment #1
ezyang commentedThanks! I'll apply it when I get a chance.
Comment #2
ezyang commentedCommitted to CVS.