Was reviewing your changes for a Drupal Gardens code update. We'll use the 7--1 branch and not the forked (Drupal 6) HEAD that we did before. Looking at changes on the branch however, it looks like you have elaborate checking of PHP versions. You try to ensure at two places that at least PHP 5.0.0 is used. Drupal 7 will not run with anything but PHP 5.2.4+ so checking this in Drupal 7 is futile and extra code that you can easily get rid of.

Here is a simple patch.

CommentFileSizeAuthor
remove-php5-checking.patch2.08 KBgábor hojtsy

Comments

ezyang’s picture

Thanks! I'll apply it when I get a chance.

ezyang’s picture

Status: Needs review » Fixed

Committed to CVS.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.