This involved a lot of tasks, but we're getting close.
DEMO SITE: http://bluecheese-groups.redesign.devdrupal.org/ user/pass: drupal/drupal, then log in as bacon/bacon.
Bluecheese have been deployed on g.d.o and is now available for testing. Got to your profile click the edit, scroll down, choose bluecheese, and poke around the site.
---------------------------
Known issues:
No possibility to choose style for pane:
#1412158: ability to control styles got lost with latest version of panels
Only "defaults" view available for panes:
#1416948: Missing display options when adding an 'og_content_list' panel pane
#1412160: only some view displays are available
Progress on dev site
(also in lullapad http://lullapad.com/WBjmxIlIGI)
Bluecheese clean-up
| add new styles for panels, replace rounded corners | will be done after styles issue #1412158: ability to control styles got lost with latest version of panels is fixed |
and style tr.odd .form-item, tr.even .form-item { white-space:nowrap } - not sure what to do with this, might be an option to just set admin theme back to blue beach Admin theme is now Garland |
|
| change favicon to specific for g.d.o | - |
Home page redesign
1. Change order of items in top navigation to: Recent Groups Events Jobs done
Remove "My account" item (there is "Logged in as" link). done
Remove "Login" item. done
2. Create static About page and add it to top navigation. done http://bluecheese-groups.redesign.devdrupal.org/about
3. Add default userpic done
4. Implement home page redesign #1074224: Redesign groups homepage for authenticated users.
- Remove "Recent" link in top navigation done
- Remove current front page content done
For anonymous visitors
(http://drupal.org/files/GDO%20front%20page%20not%20logged%20in.png):
- Move the mission text to a custom block shown only on the top of front page. done
- Add block "Browse groups" under mission block on front page done
- Implement "Recent activity" list with all posts across g.d.o in chronological order, most recent on top done
- Implement sidebar blocks on front page done
For logged in visitors
(http://drupal.org/files/GDO%20front%20page%20logged%20in.png):
- Implement "Recent activity" list with all posts across g.d.o in chronological order, most recent on top. done
- On the front page implement "Activity in your groups" list - all posts in user's groups, in chronological order, most recent on top. done
Switch front page for logged in users from "/all" to "/front" not done #1416764: Provide option to switch front page for logged in user
Related issues
Deployment
drush -y vset theme_default bluecheese
drush -y vdel site_mission
Remove Log in and My account from primary links
Add default userpic (suggested http://dl.dropbox.com/u/33894147/default-user1.png)
| Comment | File | Size | Author |
|---|---|---|---|
| #26 | Screen shot 2012-03-05 at 11.32.18 AM.png | 37.4 KB | twardnw |
| #19 | styles-and-patch.zip | 1.39 KB | tvn |
| #15 | media-gdo.png | 106.21 KB | tvn |
Comments
Comment #1
gregglesThe og_panels homepage issue seems like it was mostly caused by an issue that also affected some pages on d.o - the code referenced in #970776: node/NID/edit/issues has unbalanced layout is now merged, deployed and pretty much fixes the group homepages.
Comment #2
realityloop commentedIntegrate improvements to comment/voting display http://groups.drupal.org/node/65763
Comment #3
lisarex commentedNew homepage issue: #1074224: Redesign groups homepage for authenticated users.
(Priority set to major for our upcoming sprint; all issues that will need review with the new theme.)
Comment #4
lisarex commentedPostponed until #1054426: Groups.drupal.org redesign navigation is fixed, perhaps even some big wins like #1074224: Redesign groups homepage for authenticated users. or #954708: Redesign groups.drupal.org events view
Comment #5
christefano commentedJust want to chime in and say we'd like to help this issue along at a theme-related code sprint at this year's design camp in Los Angeles.
Comment #6
greggles@christefano - current status is waiting on #1386716: Clean up crosssite module.
Comment #7
drummI went ahead and updated drupalorg and bluecheese to deploy http://bluecheese-groups.redesign.devdrupal.org/. I put what I've done in the deployment section of the issue summary.
I think the next big win is enabling the theme, but not making it the default, on live, to get block arrangement done. Blocks don't appreciate programatic change, so configuration on live is best.
Comment #8
christefano commentedThis looks great. Is there a way to see the site as a logged-in user?
Comment #9
drummActually, now that I look at it more, blocks do not need re-placement for now. I was thrown off by the login block. A few recommendations for configuration changes on the live site:
- Disable the login block. There is a login link in the primary navigation
- Show Working and regional Groups & Meetups and Hot content this week blocks only on the home page instead of every page
- Move the mission text to a custom block shown only on the front page. This follows a pattern like "Help Us Maintain Documentation" at http://drupal.org/documentation
- Change the site name from groups.drupal.org to Drupal Groups. The site names have been moving to "Drupal Something"
Comment #10
drummLogging in - the dev sites have had their password hashes zeroed out for privacy & security. You can log in with drush uli, I sent a URL from that to your contact form. If you can help out with site building, see http://drupal.org/node/1018084.
Comment #11
lisarex commentedCool!
Agree with drumm in #9 about disabling the login block.
"Working and regional Groups & Meetups" title doesn't make sense... can we change it back to New Groups as it is on live?
As for showing Hot Content and the group list, they should probably appear on all non-group-specific pages ... e.g. /groups would be naked without those blocks. Unless there are some other blocks that could go there instead.
Comment #12
webchickIf you want to test as a logged-in user, try user bacon, pass bacon.
Mmmm. Bacon.
Comment #12.0
webchickAdd deployment steps
Comment #13
moshe weitzman commentedIt is great to see consistency come to gdo. Thanks for the progress here. At the same time, a dense information site like GDO really suffers with the fixed width design of bluecheese. Expand your browser wide and compare:
http://groups.drupal.org/nyc
http://bluecheese-groups.redesign.devdrupal.org/nyc
Dunno what we can really do about it but I'd like to register a complaint :)
Comment #14
gregglescomplained registered, but in order to make it actionable I'll need 1.21 gigawatts for my flux capacitor.
I'll probably do this tomorrow based on drumm's advice in #7 and the set of tasks (altered to match #7) in the summary.
Comment #15
tvn commentedOne of the possible ways to make group look so-so ok with the new fixed layout will be to disable "show sidebar blocks", like Media group does. Though currently it still looks not so good on dev site. We will need to let group content expand on all 12 grids instead of 8, it will look like this then:
I will be going over missing/needs change styles in the next couple of days + work needs to be done to implement #1074224: Redesign groups homepage for authenticated users.. Let's please not turn Bluecheese on on the live site until we are done with that to make sure g.d.o looks really good before switch!
Comment #16
gregglesLargely deployed based on drumm's advice. A few folks in #drupal-contrib tested it out and found some issues. I fixed some and redirected others to queues like this one or bluecheese.
tvn is working on fixing up more things :)
Comment #17
gregglesp.s. a remaining task here, IMO, is to get some better styling around blocks on the og_panels pages. See http://groups.drupal.org/denver-boulder-colorado-dbug or http://groups.drupal.org/la as examples of pages where the rounded corners + tons of padding feels incongruous with the rest of d.o style. I agree with xjm about suggesting folks enable the "hide blocks" feature.
Comment #17.0
gregglesAdding demo site info.
Comment #18
tvn commentedI've updated issue summary with the remaining tasks I came up with for now.
Comment #18.0
tvn commentedadded latest list of tasks
Comment #18.1
tvn commentedsome edits
Comment #18.2
dave reidadded 1 more item
Comment #18.3
tvn commentedadded lullapad link
Comment #18.4
tvn commentedupdating status
Comment #18.5
tvn commentedmore updates
Comment #19
tvn commentedUpdated issue summary again with current progress.
Attached is archive with css file for groupsorg module and patch to add styles + changes from #1427708: Allow group's content expand on grid-12 when right sidebar is empty.
Comment #20
drummReal quick feedback on making full-width pages. I have not fully reviewed things outside of http://pastie.org/3329643.
On other parts of the site, we use
<div class="grid-12 alpha omega">in the main content area to expand it. THis doesn't come with the extra page template that mostly duplicates the one page template.In general, I'd like to keep the CSS and other theme elements centralized as much as practical. That should help sites be consistent, including if any groups-specific elements get deployed on other sites. I might be moving some stuff out of groupsorg-styles.css for this.
Comment #20.0
drummsome fixes
Comment #20.1
tvn commentedadded logo link
Comment #21
drummRemember, any configuration that isn't done on the live site is not actually done. For example, "Move the mission text to a custom block shown only on the top of front page." hasn't happened on the live site.
Any configuration that won't work with the old theme needs to have clear deployment instructions in the issue summary.
Comment #21.0
drummadded another issue
Comment #22
drummI did a bit of cleanup for the mission, bringing it more in line with http://drupal.org/ and http://localize.drupal.org/. The rounded green box didn't really fit wit th. I decided on a more "action-oriented" heading, since we don't need to restate that we are on groups.drupal.org. I added some grid classes so it doesn't take up too much vertical space. I updated the block on the live site to match, so it is ready to deploy.
I also removed a couple of the sidebar styles to keep the site consistent with Drupal.org.
Comment #23
drummThe remaining work is
.activityCSS to match Bluecheese's styles. In general- vertical measurements should be in em matching up to increments of the line height, which comes out to 9px for half a line and 18px for full; horizontal sohuld match the grid system whenever practical.Comment #24
drummI fixed up the overlap with votes in comments by adding
overflow: hidden;to blockquote, ul, and ol. This makes those elements fit into the available width, fixing them for any time we have something to the left, like an image.Where can I find an example of the
gdo-onlineclass being used?Comment #25
tvn commented#21 - Yes, the status list in the issue summary is "Progress on dev site", so by done I meant that its done on dev not live.
Lullapad (http://lullapad.com/WBjmxIlIGI) has names of views/blocks/custom pages for each configuration. I will add them to issue summary.
#22 - Mission styles applied not only to front page, but to mission statements for groups, now they have no visual prominence at all compared with the rest of group content (I am not advocating for the green box but they should have at least something).
2 columns on front page mission look great, but it needs some white space above and below.
The sidebar styles (particularly white border) I added because while on d.o sidebar rarely has multiple blocks, on g.d.o it's usually from 5 and up - they need some visual separation from one another.
#24 gdo-online is for "Currently online" block on sidebar of front page (hard to catch it on dev site as usually noone is there).
Comment #26
twardnw commentedI noticed a problem between the Votes and a quote.
http://groups.drupal.org/node/213898
Comment #27
drummI actually just committed a fix for this, #1424454: Updown voting widget overlaps blockquote "quote" graphic. At some point, we will need to destroy this dev site and set up a new one with updated everything. As of right now, groups.staging.devdrupal.org has everything which has been committed.
Comment #27.0
kingandyUpdate deployment
Comment #27.1
tvn commentedupdating deployment instructions
Comment #27.2
tvn commentedmore updates
Comment #29
tvn commentedI updated deployment section of issue summary with configuration changes, I am not sure how detailed it should be. If there are any questions, I am usually available at #drupal-groups irc.
Comment #30
webchickTagging.
Comment #31
gregglesWe're still waiting on a resolution to #969940-19: Deploy bluecheese on groups.drupal.org and #969940-20: Deploy bluecheese on groups.drupal.org right?
Comment #32
drumm#19 and #20 are fixed. The only CSS additions remaining in groups_drupalorg go with the new views. We are good to go, except for those. The views must be exported to code with features anyway.
I don't think #1416764: Provide option to switch front page for logged in user is really a blocker. I'm removing it from the issue summary.
I would like to do a round of disabling non-essential blocks and double checking that configuration actually has made it to the live site. Blocks shnould always be contextually-relevant. Group pages should only have blocks specific to the group.
Comment #32.0
drummtypo fixes
Comment #33
drummFor the about page, I saw http://bluecheese-groups.redesign.devdrupal.org/about replaces http://bluecheese-groups.redesign.devdrupal.org/node/302. I don't see a good reason to do this. Since this is a post in the group, the sidebar is useful. Revisions to the content need to happen on the live site, http://groups.drupal.org/about. If we want the layout, use markup like
<div class="grid-2">.Comment #34
drummI filed #1482908: Revise about page content for the about page content. The dev site is now back to the old about page.
Comment #34.0
drummRemove non-blocker
Comment #34.1
drummAbout page.
Comment #34.2
drummabout page
Comment #34.3
drummCrossing out finished theme changes.
Comment #35
drummI crossed out a bit in the issue summary to mark things a truly done.
Is there a page to try out "fix nested taxonomy lists not having margins" on?
Has anyone other than tvn looked at the new home page and other view changes, like replacing http://groups.drupal.org/unread?
Comment #36
tvn commented#33 The point was for About page not to be post in a group, but to replace it with static page. It was discussed at #1054426: Groups.drupal.org redesign navigation. I simply took current About post content and put it on a new page. I do not think it needs any sidebar. I used custom page with panes instead of usual node type page just to show how it would ideally look like, without "posted by ..." and author userpic.
#35 You can see such a list at http://groups.drupal.org/australia - Location list at sidebar.
Comment #37
drummI committed a fix for "fix nested taxonomy lists not having margins" to Bluecheese, making the margin rule less specific.
Comment #37.0
drummcross out more
Comment #37.1
drummFixed that
Comment #37.2
drummAlready done
Comment #37.3
drummBlocks are arranged enough.
Comment #38
drummI think this is ready enough to deploy. #1074224: Redesign groups homepage for authenticated users., #1484712: Whitespace between header and main content should be added consistently, and other followups don't need to block this.
Comment #39
webchickYESSSSSS
Comment #40
christefano commentedWhat are the necessary steps for reducing the sidebar width so that the sidebar isn't so gargantuan on groups.drupal.org?
Re: #15, I don't think that asking every group and group organizer to disable the blocks in the sidebar is going to be easy — and IMHO, the wonkingly huge sidebars will reflect badly on groups.drupal.org in general.
Comment #41
drummchristefano - that would be a separate issue. All Drupal.org sidebars are a standard width. For Groups, we could slim down the sidebar a bit more, such as removing "Hot content this week" when the main pages have this info, #1074224: Redesign groups homepage for authenticated users.. #951114: Support all screen sizes should help out too.
Comment #42
drummDeployed this round of work.
Comment #43
drummThe dev site is quite messy now. I believe everything for followup issues is saved on Drupal.org, so I'll be destroying it and making a new one.
Comment #44
tvn commentedCross-linking request to bring "My groups" block back on group pages #1504510: Restore the "my groups" block on g.d.o
Also seems "fix nested taxonomy lists not having margins" have not been deployed? (No margins on http://groups.drupal.org/australia still for example)
Comment #45
drummFor nested taxonomy lists - we hadn't cleared the css/js cache, which is done now.
Comment #46.0
(not verified) commentedMove 1074224 to 1074224