Updating documentation.. patch coming.

Comments

nomonstersinme’s picture

Status: Active » Needs review
StatusFileSize
new3.86 KB
moonray’s picture

Status: Needs review » Needs work

This is because we are making use of the contextual links that come with Drupal 7.

Actually, it is because D7 has a new way of handling classes that allows skinr to inject them at the preprocess level. See http://drupal.org/node/254940#html-class-variable

nomonstersinme’s picture

Status: Needs work » Needs review
StatusFileSize
new4 KB

LOL thank you for that... i knew i wasn't right but was being lazy ;)

sun’s picture

+++ help/theme.html	19 Nov 2010 17:16:09 -0000
@@ -1,38 +1,11 @@
+<p>In Drupal 6 to make Skinr work with your theme you had to print the <code>$skinr

variable in any template file you wanted to be able to manipulate with Skinr. In Drupal 7, for the most part, this is not necessary. You can alter blocks, nodes, views and panels without separate template files. This is because Drupal 7 handles classes differently, and Skinr is able to insert classes at the preprocess level. There are however, a couple of suggested templates you should create and print the contextual links for easier Skinr use.

Why do we document Drupal 6 stuff in a Drupal 7 module? Users that never used Drupal 6 can't make any sense of this Drupal core major version evolution and API change drama.

Overall, most of this help text seems to duplicate existing Drupal core documentation elsewhere that themers should already be familiar with.

Powered by Dreditor.

Status: Needs review » Needs work

The last submitted patch, skinr-970130-3.patch, failed testing.

nomonstersinme’s picture

Status: Needs work » Needs review
StatusFileSize
new3.67 KB

Ok i don't particularly agree but Bala suggested a separate doc for changes between 6 and 7... so for now I removed all mention of drupal 6. :)

Status: Needs review » Needs work

The last submitted patch, skinr-970130-6.patch, failed testing.

moonray’s picture

Status: Needs work » Closed (won't fix)

See skinr.org for documentation; we're no longer using advanced help for it.