Several bugs around outputting
gerd riesselmann - November 11, 2006 - 22:28
| Project: | Amazon Filter |
| Version: | 4.7.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | closed |
Jump to:
Description
The patch attached fixes the following problems:
- Do not try to get image size (fails on some systems)
- Invoke theme_amazon_filter through theme(), not directly, so it can be overloaded
- Make filter work for more than one amazon filter tag in the body text
- Make it output at least something, that is: use $product properties that actually exist
- Get rid of the warning when no author exists
Additionally I'd like to say that the absence of any README or documentation made it rather hard to discover how this module works.
| Attachment | Size |
|---|---|
| amazon_filter.diff | 1.6 KB |
#1
Just a quick thumbs-up. This patch fixed every issue listed; the module's actually usable now :) Thanks!
#2
I run into these same issues, unfortunately I found this patch only after I fixed them myself.
Please apply patch ASAP.
#3
Both the 4.7 versions and the new 5 versions have been updated, though no official release is yet out. Check http://drupal.org/node/118902 and http://drupal.org/node/96504 for the latest code.
Apologies on the long wait for these patches; the module was originally released a a quick hack and I haven't had much time to update or even look at it. Recent work on the ASIN module got me back into the code, though.
#4
#5