I am using drush make to download the jquery cycle plugin using this code:

; jQuery Cycle
libraries[jquery_cycle][download][type] = "get"
libraries[jquery_cycle][download][url] = "http://www.malsup.com/jquery/cycle/release/jquery.cycle.zip?v2.86"
libraries[jquery_cycle][directory_name] = "jquery.cycle"
libraries[jquery_cycle][destination] = "libraries"

This works as expected except that all of the contents do not end up in /sites/all/libraries/jquery.cycle

if I wget the same url and unzip it there is a directory called "src" as well as a readme and a couple other files that do not show up when I use drush make to fetch the plugin.

Am I missing a setting in my code?

Thanks!

CommentFileSizeAuthor
drush_make_output.png33.61 KBRockSoup
unzipped_manually.png59.85 KBRockSoup

Comments

dmitrig01’s picture

dmitrig01 commented

woah, this is bad. working on it.

dmitrig01’s picture

dmitrig01 commented
Status: Active » Fixed

Took me 2 days but fixed the bug and

 drush_make.download.inc |  110 ++++++++++++------------------------------------
 1 file changed, 28 insertions(+), 82 deletions(-)
guddomeNt’s picture

guddomeNt commented

So .. What was the fix?

I don't know if it's related, but I noticed that unzip can cause the script to stall. Adding -o option to the command line call fixes it. (What happens is that if a file is to be overwritten, unzip will prompt the user).

bryanhirsch’s picture

bryanhirsch commented

I think I've got the same issue. I'm trying to download a library, but several files are missing after the drush_make is done doing its thing.

@dmitrig01, sounds like you fixed it. Is there a patch?

In case my issue is not the same, here are the details of what's going on.

This is what I have in my .make file: 

267 ; Libraries
268 
269 libraries[imageflow][download][type] = "get"
270 libraries[imageflow][download][url] = "http://finnrudolph.de/content/ImageFlow_1.3.0.zip"

(I'm trying to include this library in my install profile: http://finnrudolph.de/ImageFlow/Download)
These are the files I've got after drush_make is done: 

$ ls
img1.png  img2.png  img3.png  img4.png

These are the files I should have: 

$ ls
button_left.png   button_play.png   favicon.ico    imageflow.js          imageflow.packed.js  index.html    reflect3.php     slider.png
button_pause.png  button_right.png  imageflow.css  imageflow.packed.css  img                  reflect2.php  slider_dark.png  style.css
$ ls img/
img1.png  img2.png  img3.png  img4.png

Is this the issue you fixed?

Thanks for all your work on this @dmitrig01. drush_make is awesome!

dmitrig01’s picture

dmitrig01 commented

it's in the latest cvs

bryanhirsch’s picture

bryanhirsch commented

Just downloaded 2.0-dev from CVS. That did the trick. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

bryanhirsch’s picture

bryanhirsch commented
Version: 6.x-2.0-beta9 » 6.x-2.0-beta10

I just installed 6.x-2.0-beta10. Now the same issue from comment #4 is back. :(

bryanhirsch’s picture

bryanhirsch commented
Status: Closed (fixed) » Active

setting status to active.

dmitrig01’s picture

dmitrig01 commented
Status: Active » Fixed

hm, looks like it's still fixed in CVS. I'm going to roll another beta soon.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.