Posted by higherform on November 13, 2010 at 5:49pm
3 followers
Jump to:
| Project: | Mailfix for Postfix |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | higherform |
| Status: | needs review |
| Issue tags: | drupal mail, drupal multisite, features |
Issue Summary
Nigel -
I meant to post on this a long time ago, but we have been working on a major feature set for this module that will allow:
1. Multiple sites to control one or more domains on the same server
2. User control of vacation responders
3. User control of forwarding
4. UI changes, simplifcation, descriptions, etc
and more
We forked from 6.x-1.6 release so it should not be too far to pull these features back to the trunk. I will include a diff but I do not recommend committing it just yet, mostly because I know its not up to Drupal coding standards in a lot of places. Take a look through the direction we are heading, see if you can think of anything that should be simpler, obvious flaws, etc...
| Attachment | Size |
|---|---|
| mailfix-features-higherform-20101113.patch | 44.58 KB |
Comments
#1
For multisite to work correctly, all sites need to be writing to / reading from common mailfix tables. Adding this to settings.php will take care of this easily:
$db_prefix = array(
'mailfix_users' => 'drupal6_mailfix.',
'mailfix_domains' => 'drupal6_mailfix.',
'mailfix_aliases' => 'drupal6_mailfix.',
);
#2
So is this integration with the domain module, or some other module?
I've taken a quick look, and don't mind merging most of it (though I'd separate out each bit of new functionality).
I'm often slow to reply - too many things to do and not enough time - but will seek to give this a more detailed look in the coming week.
#3
Hi again.
I've been looking through this some more, and have some more feedback:
1) As mentioned in the previous message, I'd like to apply the changes as discrete patches: autoresponding, site ids, mail aliases, rename of forward to redirect...
2) Why make a copy of the user's status, password etc?
3) While I agree with renaming 'forward' to 'redirect', we need to also either (1) Make it very clear to users that the fieldname has changed and they need to update Postfix settings to match OR (2) change the user interface, but leave the database field name the same. I'm half tempted to do the later to make upgrading a non-issue, but reckon the former is preferable - it's cleaner, going forward. What do you think?
4) What's with the prefixing table names?
5) In mailfix_user, you have the access test commented out. That's not intended for merging, right? (IIRC, I've pushed the access testing down into the called functions, anyway).
6) I agree about using drupal_write_record - noting here so it gets remembered.
7) The TODO list at the end looks worthy of further consideration.
Thanks for your work!
#4
so guys, how's it going? the thing is great, and will be even better with this improvements. Good luck!
#5
Too much work, not enough time. :) I'm doing a little spurt this afternoon, and will look at this again shortly.