Download & Extend

destination address does not track account email change

Project:Messaging
Version:6.x-4.x-dev
Component:Code
Category:bug report
Priority:critical
Assigned:Unassigned
Status:needs review

Issue Summary

When a user changes their email address, the messaging destination address does not track. You have to change the send method in the account settings to something else, save, then change back.

IMHO the email addresses should track or messaging should always pull the account email address for any mail based messages.

Comments

#1

What's also not right is that the mail option test in messaging settings will send to the user's account address, but notifications messages are sent to the messaging_destinations address. There's a disconnect there someplace.

#2

Priority:normal» critical

this is a truly annoying bug. i'm changing it to urgent. not sure how to address it.

#3

Status:active» needs review

See attached patch for a solution.

I have added a function to update addresses in the message_destination table for any message type and then in messaging_mail, messaging_mime_mail, messaging_phpmailer & messaging_sms added function to hook into user updating these details and update these.

I haven't used another other message types, so they may need to still be updated.

AttachmentSize
0001-970936-update-destination-address-for-mail-mimemail-.patch 7.09 KB

#4

Here it is a normal patch as well.

AttachmentSize
messaging-970936-4.patch 5.94 KB

#5

Actually seems the fix is a little simpler then I first thought and don't need to repeat the changes for mime_mail and phpmailer as they inherit the messaging_mail destination, so I can remove half the changes from the above patch.

AttachmentSize
messaging-970936-5.patch 4.29 KB

#6

Version:6.x-4.0-beta7» 6.x-4.x-dev

Thanks - Attached is a rerolled patch against latest dev.

Tested and works for user email changes. Is anyone able to test the the SMS amends?

AttachmentSize
messaging-update-destination-970936-6.patch 3.72 KB