If we can introduce helpers/ callbacks like in the D7 filter system, then porting to D7 becomes easier as well as maintaining all branches.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | chessboard-refactor-filter-971014-2.patch | 9.31 KB | eric_a |
| #1 | chessboard-refactor-filter-971014-1.patch | 8.99 KB | eric_a |
Comments
Comment #1
eric_a commentedThis patch introduces D7 style functions, which seems doable in this D6 branche. We're passing a fake filter object (process) or no objects at all (tips), but it becomes easier to maintain our code.
The _chessboard_filter_callback() function now gets a filter object passed instead of a format ID. It's a private function, I don't consider this an API change.
Comment #2
eric_a commentedcontaining the replacement text.
*/
-function _chessboard_filter_callback($matches, $set_format = NULL) {
containing the replacement text.
*/
-function _chessboard_filter_callback($matches, $set_format = NULL) {
Comment #4
eric_a commented#2: chessboard-refactor-filter-971014-2.patch queued for re-testing.
Comment #5
eric_a commentedCommitted.