If the class file in question is under GPL then why isn't it just incorporated into the module source? Why force us to register with a 3rd party site to access the code?

Comments

Dustin Currie’s picture

Dustin Currie commented

See Drupal.org CVS policy on 3rd party code: http://drupal.org/node/422996

TomDude48’s picture

TomDude48 commented

I would love to embed it into the module. However, committing 3rd party code seems to be generally frowned upon so I tend to avoid it.

If the contrib powers that be say it is OK, then I will do it. Until then I err on the side of caution.

TomDude48’s picture

TomDude48 commented
Status: Active » Closed (works as designed)
xtfer’s picture

xtfer commented
Status: Closed (works as designed) » Needs review

As a follow up, I can't even get PHPClasses to recognise my login currently, so I am unable to download the class at all. That should be sufficient for inclusion.

Also, if you arent planning on including it, perhaps putting it under /Sites/all/libraries would be more appropriate?

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Version: 6.x-1.x-dev » 7.x-1.0-beta3

Seems to be available here, as well, without any registration mumbo-jumbo: http://www.syncrat.com/6hn

Someone should set up a github repo.

Also +1 on the Libraries dependency.