Attached is a patch which upgrades this module to be compatible with 6.x. It also cleans up code formatting issues. The module will enable in 6.x. after applying this patch, however I have not tested out functionality yet.

CommentFileSizeAuthor
upcoming_event.patch10.23 KBcoderintherye

Comments

ipwa’s picture

ipwa commented

Thanks nowarninglabel I will start a D6 branch with your patch.

coderintherye’s picture

coderintherye commented

Excellent, just a note to others looking for 6.x. The current patch needs some work, it will get you a working module, but is not quite usable yet, still some cleanup needed on menus, and something with connecting to the API isn't working yet, so I'll need to figure that out. Will be working on it again this weekend.

ipwa’s picture

ipwa commented

Awesome thanks, it'll still be good to get kick started on the D6 branch. I'll commit the code later today, and if you're thinking on continue to work on this patch, I'll be happy to add you as a co-maintainer.

coderintherye’s picture

coderintherye commented

Yes, I will definitely be continuing work in this area, so if you add me as a co-maintainer I will probably check out the dev snapshot once it is up and then update with a new version this week. Looks like I will also get added as co-maintainer to GCal API, so will be good to work on these in tandem due to the similarities. (And now is the best time due to holiday breaks giving some extra time).

ipwa’s picture

ipwa commented

I already committed your code, thanks. There will be a dev snapshot soon, I can;t add you as a maintainer right now, because I don;t have permissions for it since Develcuy is still the author of this project (node). I will get him to change the author user to me and I;ll add you as a co-maintainer then. Thanks so much!!!!!!

coderintherye’s picture

coderintherye commented

Sounds good, please post here or send me a message when I am added, and I will then do a checkout and work on the dev release directly.

ipwa’s picture

ipwa commented
Version: 5.x-1.x-dev » 6.x-1.x-dev
Assigned: Unassigned » ipwa
Status: Active » Needs review

OK, now we have a 6.x branch and dev release ready to download from the module page. Be careful though Kevin because the patch for .module didn't apply cleanly:

Hunk #9 FAILED at 242.
Hunk #18 FAILED at 572.
Hunk #19 succeeded at 599 (offset -1 lines).
Hunk #20 succeeded at 625 (offset -1 lines).
Hunk #21 succeeded at 678 (offset -2 lines).
Hunk #22 FAILED at 706.

So you might want to run a diff with your local code when you checkout the d6 branch.

For anyone interested @nowarninglabel is officially the co-maintainer and has CVS access to the module. Yay!!

coderintherye’s picture

coderintherye commented

Yay, awesome will work on this tonight.

And yes, for those following along, please don't apply this patch, but rather work off the new dev release, although you might want to wait until after this weekend when the release will be more stable. I don't plan on writing an upgrade path right away unless someone needs it, so open a feature request if you do. Cheers.

coderintherye’s picture

coderintherye commented
Status: Needs review » Fixed

Ok this is fixed because we have a 6.x release now.

Status: Fixed » Closed (fixed)
Issue tags: -6x upgrade

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +6x upgrade

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.