There is a bug in jquery 1.4.4 (see here) which breaks theme developer.

We don't need the attributes of the document object for the popup, so will remove it from the parent list to be able to work with this bug.

Comments

JeremyFrench’s picture

StatusFileSize
new400 bytes

Patch attached.

JeremyFrench’s picture

Status: Active » Fixed

Commited Here,should appear in nightly build tomorrow.

JeremyFrench’s picture

Actually that bug is fixed in Jquery 1.4.4 but it seems to be related.

JeremyFrench’s picture

jQuery issue is #7517

juhaniemi’s picture

Tried out the patch and the CVS version and I still get this JS error (as shown in Firebug).

a.attributes is null
b.specified?b.value:Va.test(a.nodeName...a,"\\$&")},ua={focusin:0,focusout:0}; 
jquery.js?v=1.4.4 (line 57)

Did this patch suppose to work around the jQuery issue or do we need to wait for a fix to jQuery to get this working?

JeremyFrench’s picture

Status: Fixed » Postponed (maintainer needs more info)

This works, or should work, around the Jquery issue.

That is the error which should be fixed. Can you confirm patch applied and is being served.

If you check devel_themer in firebug line 138 or so should read

 if ((obj && obj.parentNode) && (obj.nodeType != 9)

The new bit is the obj.nodeType != 9. It is possible that the bug occours eleswhere in the code, but theme developer was broken with Beta 3 for me and this fixed it.

juhaniemi’s picture

Status: Postponed (maintainer needs more info) » Fixed

Double-checked that I have the patch applied. Line 138 has && (obj.nodeType != 9).

After applying the patch I see the red outlines around div's but nothing happens after clicking on them. When I pop-up Firebug inspector, JS errors start counting when I click on the elements.

Tested on Firefox 3.6 Mac and replicated on Safari 5. Vanilla Drupal 7-beta3.

juhaniemi’s picture

Status: Fixed » Postponed (maintainer needs more info)
JeremyFrench’s picture

Status: Postponed (maintainer needs more info) » Needs work

ok, will investigate some more, thank you.

JeremyFrench’s picture

Status: Needs work » Needs review
StatusFileSize
new759 bytes

Messed up when creating the patch. Altered the wrong line.

This patch should do the trick

juhaniemi’s picture

Status: Needs review » Reviewed & tested by the community

Thanks, now it's working. :)

JeremyFrench’s picture

Assigned: JeremyFrench » Unassigned
Status: Reviewed & tested by the community » Fixed

Commited here.

mermentau’s picture

StatusFileSize
new29.14 KB

I have applied the patch to the latest Dev version 2010-Nov-15 and while the pop-up is now showing data I do get a 500 server error which I have attached as a screen shot.

JeremyFrench’s picture

@bumpaw
I think I have seen that before on occasion, I don't think it is related to the jquery bug, I'll investigate some more tomorrow.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

wwedding’s picture

Status: Closed (fixed) » Needs review

This seems to still be an issue, but all activity in this bug seems to have stopped. My error console is still giving me a.attributes is null when I attempt to click anything. The red boxes work fine, though.

JeremyFrench’s picture

Status: Needs review » Postponed (maintainer needs more info)

Hi Stickywes.
It looked as though this bug was fixed, a patch was created tested and committed, so no further work was being done.

Can you confirm the Drupal version and the build of theme developer you are using? I'll see if I can recreate with that combination?

wwedding’s picture

Sure,

Theme Developer version: 7.x-1.x-dev
Drupal Version: 7.0.rc1
Browser is Safari, I also hit this in Mozilla.

wwedding’s picture

To make sure this isn't specific to my work environment (where the problem is happening) I'm going to toss a brand new fresh install onto another machine and will update later today if the problem persists over there. I plan to use Drupal 7 for some personal web work so this seems as good an opportunity as any to test this more thoroughly for you!

JeremyFrench’s picture

Thanks very much for double checking. I look forward to your findings.

JeremyFrench’s picture

Status: Postponed (maintainer needs more info) » Closed (fixed)

Closing as no feedback given and nobody else reporting

datarazor’s picture

Problem still happening, I can't drag the theme_devel pop up without throwing:

F is null
[Break On This Error] 

sites/default/modules/jquery_update/replace/jquery.min.js?9

I have to run jquery_update 6.x-2.x-dev (2009-Apr-23) in order for Lightbox 2 and other jquery tools to work.
My jquery_ui is jQuery UI 6.x-1.4
Devel is Devel 6.x-1.x-dev (2011-Jan-16) which resolved SOME of the jquery errors in theme_developer, but not all.

Drupal 6.20

Here are all my script packages. Nivo is an image carousel controller:

/sites/default/modules/jquery_update/replace/jquery.min.js?9  
/misc/drupal.js?9  
/sites/all/modules/admin_menu/admin_menu.js?9  
/sites/all/modules/panels/js/panels.js?9  
/sites/default/modules/devel/krumo/krumo.js?9  
/sites/default/modules/devel/devel_themer.js?9  
/sites/default/modules/devel/ui.mouse.js?9  
/sites/default/modules/devel/ui.draggable.js?9  
/sites/default/modules/fivestar/js/fivestar.js?9  
/sites/default/modules/swftools/shared/swfobject2/swfobject.js?9  
/sites/all/modules/jquery_ui/jquery.ui/ui/minified/ui.core.min.js?9  
/sites/all/modules/jquery_ui/jquery.ui/ui/minified/ui.draggable.min.js?9  
/sites/all/modules/jquery_ui/jquery.ui/ui/minified/ui.droppable.min.js?9  
/sites/all/modules/jquery_ui/jquery.ui/ui/minified/ui.sortable.min.js?9  
/sites/default/modules/context/plugins/context_reaction_block.js?9  
/sites/all/themes/mytheme_v2/js/core.js?9  
/sites/all/themes/mytheme_v2/js/jquery.nivo.slider.pack.js?9  

core.js only does some very simple things like add a class depending on screen width:

//CSS fix for the iframe to ensure it is full-width in this liquid design:
function iframeSize () {
	var setValue = $("body").width() -272;
	$('#iframe-0').css("width",setValue);
}

Thanks for any help you can offer!

EDIT: Do I need to make a new ticket if this is in D6.20? Just noticed this ticket is D7...
EDIT2: If I have the time I will start to disable potential conflicting modules to isolate the JS interaction problem.

datarazor’s picture

Priority: Critical » Normal
Status: Closed (fixed) » Needs review

Also have problems on any page with the weight feature:

$(".indentation", testCell).get(1) is undefined
[Break On This Error] this.indentAmount = $('.indentatio...tation', testCell).get(0).offsetLeft; 

Turning of theme_devel stops the problem from occurring.

datarazor’s picture

Oh and this error also from tablehead.js in /misc/ when theme_devel is active:

document.body is null
[Break On This Error] var hScroll = document.documentEle...rollLeft || document.body.scrollLeft; 
JeremyFrench’s picture

Status: Needs review » Closed (fixed)

Can you start a new issue for this. It isn't the same issue that was in D7, I'm not sure what version query update uses, it is possible that it is jQuery causing these issues in older modules..

datarazor’s picture

yes, sorry about this, saw lots of jquery issues posted so i didn't want to make a duplicate.