There is a bug in jquery 1.4.4 (see here) which breaks theme developer.
We don't need the attributes of the document object for the popup, so will remove it from the parent list to be able to work with this bug.
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | 2010-11-15_105653.png | 29.14 KB | mermentau |
| #10 | 972050-2.patch | 759 bytes | JeremyFrench |
| #1 | 972050.patch | 400 bytes | JeremyFrench |
Comments
Comment #1
JeremyFrench commentedPatch attached.
Comment #2
JeremyFrench commentedCommited Here,should appear in nightly build tomorrow.
Comment #3
JeremyFrench commentedActually that bug is fixed in Jquery 1.4.4 but it seems to be related.
Comment #4
JeremyFrench commentedjQuery issue is #7517
Comment #5
juhaniemi commentedTried out the patch and the CVS version and I still get this JS error (as shown in Firebug).
Did this patch suppose to work around the jQuery issue or do we need to wait for a fix to jQuery to get this working?
Comment #6
JeremyFrench commentedThis works, or should work, around the Jquery issue.
That is the error which should be fixed. Can you confirm patch applied and is being served.
If you check devel_themer in firebug line 138 or so should read
The new bit is the obj.nodeType != 9. It is possible that the bug occours eleswhere in the code, but theme developer was broken with Beta 3 for me and this fixed it.
Comment #7
juhaniemi commentedDouble-checked that I have the patch applied. Line 138 has && (obj.nodeType != 9).
After applying the patch I see the red outlines around div's but nothing happens after clicking on them. When I pop-up Firebug inspector, JS errors start counting when I click on the elements.
Tested on Firefox 3.6 Mac and replicated on Safari 5. Vanilla Drupal 7-beta3.
Comment #8
juhaniemi commentedComment #9
JeremyFrench commentedok, will investigate some more, thank you.
Comment #10
JeremyFrench commentedMessed up when creating the patch. Altered the wrong line.
This patch should do the trick
Comment #11
juhaniemi commentedThanks, now it's working. :)
Comment #12
JeremyFrench commentedCommited here.
Comment #13
mermentau commentedI have applied the patch to the latest Dev version 2010-Nov-15 and while the pop-up is now showing data I do get a 500 server error which I have attached as a screen shot.
Comment #14
JeremyFrench commented@bumpaw
I think I have seen that before on occasion, I don't think it is related to the jquery bug, I'll investigate some more tomorrow.
Comment #16
wwedding commentedThis seems to still be an issue, but all activity in this bug seems to have stopped. My error console is still giving me a.attributes is null when I attempt to click anything. The red boxes work fine, though.
Comment #17
JeremyFrench commentedHi Stickywes.
It looked as though this bug was fixed, a patch was created tested and committed, so no further work was being done.
Can you confirm the Drupal version and the build of theme developer you are using? I'll see if I can recreate with that combination?
Comment #18
wwedding commentedSure,
Theme Developer version: 7.x-1.x-dev
Drupal Version: 7.0.rc1
Browser is Safari, I also hit this in Mozilla.
Comment #19
wwedding commentedTo make sure this isn't specific to my work environment (where the problem is happening) I'm going to toss a brand new fresh install onto another machine and will update later today if the problem persists over there. I plan to use Drupal 7 for some personal web work so this seems as good an opportunity as any to test this more thoroughly for you!
Comment #20
JeremyFrench commentedThanks very much for double checking. I look forward to your findings.
Comment #21
JeremyFrench commentedClosing as no feedback given and nobody else reporting
Comment #22
datarazor commentedProblem still happening, I can't drag the theme_devel pop up without throwing:
sites/default/modules/jquery_update/replace/jquery.min.js?9
I have to run jquery_update 6.x-2.x-dev (2009-Apr-23) in order for Lightbox 2 and other jquery tools to work.
My jquery_ui is jQuery UI 6.x-1.4
Devel is Devel 6.x-1.x-dev (2011-Jan-16) which resolved SOME of the jquery errors in theme_developer, but not all.
Drupal 6.20
Here are all my script packages. Nivo is an image carousel controller:
core.js only does some very simple things like add a class depending on screen width:
Thanks for any help you can offer!
EDIT: Do I need to make a new ticket if this is in D6.20? Just noticed this ticket is D7...
EDIT2: If I have the time I will start to disable potential conflicting modules to isolate the JS interaction problem.
Comment #23
datarazor commentedAlso have problems on any page with the weight feature:
Turning of theme_devel stops the problem from occurring.
Comment #24
datarazor commentedOh and this error also from tablehead.js in /misc/ when theme_devel is active:
Comment #25
JeremyFrench commentedCan you start a new issue for this. It isn't the same issue that was in D7, I'm not sure what version query update uses, it is possible that it is jQuery causing these issues in older modules..
Comment #26
datarazor commentedyes, sorry about this, saw lots of jquery issues posted so i didn't want to make a duplicate.