After installing this module, and trying to play with it by creating a new node I am getting this error message on the node/add page:

warning: date() expects parameter 2 to be long, string given in sites/all/modules/scribeseo/scribeseo.module on line 190.

CommentFileSizeAuthor
#3 scribeseo-date-function-issues-6.x-1.0-rc6-972236-3.patch1.05 KBleksat

Comments

stevethewebguy’s picture

stevethewebguy commented

You can replace line 190:
'#value' => $credits['remaining'] . ' ' . t('evaluations as of ') . date('F j, Y, g:i a', $credits['time']),

With:
'#value' => $credits['remaining'] . ' ' . t('evaluations as of ') . date('F j, Y, g:i a', strtotime($credits['time'])),

Dustin Currie’s picture

Dustin Currie commented

date() shouldn't be used in Drupal at all. Use drupal's format_date() instead. It will give you offsets for the site or user timezone and language translation.

http://api.drupal.org/api/drupal/includes--common.inc/function/format_da...

date('F j, Y, g:i a', strtotime($credits['time'])) should be

format_date(strtotime($credits['time']), 'custom', 'F j, Y, g:i a');

or better yet:

format_date(strtotime($credits['time']), 'medium');

leksat’s picture

leksat commented
StatusFileSize
new scribeseo-date-function-issues-6.x-1.0-rc6-972236-3.patch1.05 KB
randallknutson’s picture

randallknutson commented
Status: Active » Fixed

Thanks for the patch. It has been applied in rc7.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.