Error and status messages are wrapped by a div that let garland style them in a green or red box improving usability and clarity against drupal 4.7 .
Shouldn't we wrap confirm messages with a similar div, too (i.e.

)?
This happens in a lot of modules and I haven't been able to provide a patch (my php skills aren't so good).
In case someone want to help by providing a patch I can suggest to search for the string 'Are you sure you want to delete' to find which modules need to be patched.

Dodo

CommentFileSizeAuthor
#5 confirm_10.patch901 bytesRobRoy
#4 confirm_9.patch15.35 KBdodorama
#3 confirm.png7.19 KBdodorama

Comments

dodorama’s picture

dodorama commented

My example didn't display. Here it is.

<div class="messages confirm">Are you sure .... </div>
dodorama’s picture

dodorama commented
Title: wrap confirm messages with a div.messages.status » CSS: confirm messages need their own class to be styled
dodorama’s picture

dodorama commented
Status: Active » Needs review
StatusFileSize
new confirm.png7.19 KB

Here's a patch that wrap all confirm messages with their own div with class="messages confirm" ( So they are now boxed like all messages and can be easy styled via CSS )
See screenshot.

dodorama’s picture

dodorama commented
StatusFileSize
new confirm_9.patch15.35 KB

I forgot the patch

RobRoy’s picture

RobRoy commented
StatusFileSize
new confirm_10.patch901 bytes

If you're going to go that route, something like this might be cleaner.

dodorama’s picture

dodorama commented

and easier.
I've got a lot to learn...

dodorama’s picture

dodorama commented
Status: Needs review » Reviewed & tested by the community
Steven’s picture

Steven commented
Status: Reviewed & tested by the community » Needs work
  • Both patches are bad as the HTML is hardcoded. A themable function should be used.
  • Using the same class as notification messages is inappropriate.
  • The styling makes it look like the notification message is not part of the confirmation form. I would stick to just styling on some margins, rather than borders and backgrounds.
Conditi0n’s picture

Conditi0n commented
Status: Needs work » Closed (fixed)

The confirmation form is working well and the style of the notification form is not required. The topic also is inactive.