per node type settings form broken for book, other module-defined types [#97231]

Attachment functionality of upload.module can be enabled on a per-nodetype basis (radio button on node_type_form). But actually the settings are not displayed correctly for books. The problem is in hook_form_alter() the following code gets the current state variable_get('upload_'. $form['identity']['type']['#default_value'], 1), but for books the node type is in $form['identity']['type']['#value'] (for other node types, e.g. page/story it in $form['identity']['type']['#default_value']). Not sure where the issue is located exactly, but I guess it is in book.module or node type system.

Comment	File	Size	Author
#2	fix_node_type_form_0.diff	2.34 KB	pwolanin

Comments

Comment #1

profix898 commented 13 November 2006 at 16:20

Status:

Active

» Closed (duplicate)

Marking this 'duplicate'. It will be fixed by the patch in issue http://drupal.org/node/88633

Comment #2

pwolanin commented 24 November 2006 at 03:10

Assigned:	Unassigned	» pwolanin
Status:	Closed (duplicate)	» Needs review

Status	File	Size
new	fix_node_type_form_0.diff	2.34 KB

following on from http://drupal.org/node/88633#comment-159094

Attached patch should fix the problem in the $form building phase

Comment #3

pwolanin commented 24 November 2006 at 23:04

Title:

per node type settings of upload.module broken for books

» per node type settings form broken for book, other module-defined types

trying to clarify the title.

To reiterate: the bug can be observed when setting the comment or upload settings for any module-defined type. The correct settings are saved to the variables table. However, when editing the node type again the correct default values (the current settings) do not appear in the node type editing form.