In zendesk.module, line 155 if (!result){ should be changed to if (!$result){

CommentFileSizeAuthor
#5 972526.typo_fixes_5.patch1.35 KBhaza
#4 972526.typo_fixes_4.patch1.57 KBhaza
#2 972526.typo_fix.patch569 byteshaza
#1 typo_fix-972526.patch0 bytesmattcasey

Comments

mattcasey’s picture

mattcasey commented
Status: Needs work » Needs review
StatusFileSize
new typo_fix-972526.patch0 bytes

Because of this bug, Zendesk creates an empty log, which causes errors from the t() function in includes/common.inc. It was giving me watchdog errors every time I viewed the watchdog page.

Patch to latest dev attached.

haza’s picture

haza
Primary language French
commented
StatusFileSize
new 972526.typo_fix.patch569 bytes

Patch seems to be empty,

And this bug is still here.

New patch attached.

positiff’s picture

positiff commented

The same error on line 163 And the 3rd argument in watchdog function should be an array, so, at least:

watchdog('zendesk', 'error: ' . $zd->result['code'], array(), WATCHDOG_ERROR);

instead of 

watchdog('zendesk', 'error: ' . $zd->result['code'], WATCHDOG_ERROR);

in all watchdag callbacks

haza’s picture

haza
Primary language French
commented
StatusFileSize
new 972526.typo_fixes_4.patch1.57 KB

New patch with that fixes.

haza’s picture

haza
Primary language French
commented
StatusFileSize
new 972526.typo_fixes_5.patch1.35 KB

New patch against HEAD

haza’s picture

haza
Primary language French
commented
Status: Needs review » Fixed

Commited !

Status: Fixed » Closed (fixed)
Issue tags: -watchdog, -result, -zendesk.module

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +watchdog, +result, +

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.