If we can introduce a nice helper, then porting to D7 becomes easier as well as maintaining all branches.

Comments

eric_a’s picture

Status: Active » Needs review
StatusFileSize
new1.78 KB
eric_a’s picture

Status: Needs review » Fixed

Committed.

eric_a’s picture

Status: Fixed » Needs review
StatusFileSize
new1.76 KB

#972172: CSS not always added by chessboard_init() for cacheable formats [regression] got in without a test. Let's improve a little more here, in such a way that a test can pass in an array of formats. Let's separate loading and further processing.

eric_a’s picture

StatusFileSize
new1.73 KB

This one uses $format->cache instead of filter_format_allowcache($format->format).

eric_a’s picture

StatusFileSize
new2.92 KB

This one does even more separation and introduces the _chessboard_cache_get_multiple().

Status: Needs review » Needs work

The last submitted patch, chessboard-refactor-init-972602-5.patch, failed testing.

eric_a’s picture

StatusFileSize
new2.92 KB

No, $cache->cid is not going to work here, so replaced it with $cid.

eric_a’s picture

Status: Needs work » Needs review
eric_a’s picture

Status: Needs review » Fixed

Committed.

eric_a’s picture

Status: Fixed » Closed (fixed)