Update Drupal 7 installer to reflect installer form changes

@duellj It looks like you're patching against an old version. I can't find PIFR_CLIENT_DB anywhere in the project. So I used $edit['driver'].

I guess we could very easily handle things gracefully so that this patch can be committed without breaking testing, then #346494: DB drivers need to be able to change the configure database form during install can be committed without breaking testing.

Probably need to apply as hotfix to 2.2 instead of HEAD since the workers all run that.

Lets re-roll the patch per #2 so handle things gracefully and then commit a final change (without grace) to HEAD.

@duellj I'm not sure I follow. Your patch is against pifr_simpletest.client.inc,v 1.7 whereas the 6--2-2 version is pifr_simpletest.client.inc,v 1.39. Also the 6--2-2 pifr_simpletest.client.inc does not install Drupal, but allows the parent class to do that. So unless I'm missing something we should be patching pifr_drupal.client.inc,v 1.9 in 6--2-2.

Patches against 6--2-2 and HEAD are attached that should gracefully handle both before and after #346494: DB drivers need to be able to change the configure database form during install.

And by graceful I meant explosive fail. Apparently you can't just dump stuff into $edit that isn't actually in the form.

Here's patches that use xpath to determine which version to use. I can't actually get PIFR to run locally, so these should be tested.

Upping this to critical since it is blocking the resolution of a critical core issue.

no idea where the 7x. branch came form...i've noticed it on a number of projects that don't actually have any 7.x code...must be something messed up with cvs. Working on getting this deployed, but those involve don't like to get back to me.

Waiting on either #976834: Convert qa.drupal.org to bzr which will allow full update, or access to hotfix the current clients.

Updated the drupaltestbot deployment package with the patch from #8:

https://github.com/damz/drupaltestbot/commit/36518594239e8fe448d63201312...

Pushed the package on #32. Waiting for rfay to wake up for #504.

#504 is now updated too.

Updated #504 and sent an email to the other testbot managers requesting the same. This is the puppet-managed upgrade procedure DamZ specified:

apt-get update
apt-get upgrade (Say "Yes" when it asks if you want to reconfigure the db. It's OK)
puppetd --test --server puppet.damz.org

reboot

Submit testbot for retesting on qa.drupal.org.

Testing patches is overrated apparently. Next time, test a patch before whining about deploying it to the test clients.

I updated testbot #414 but get division by zero errors: http://qa.drupal.org/pifr/test/91739

I'll try a retest.

I added https://drupal.org/files/issues/pifr-d7-installer-972956-9_6--2-2.diff to #33 and submitted for retest.

Once the core issue has been resolved I will commit the following or something like it to HEAD.

@DamZ Sorry about this mess. I thought patch had been tested and I had updated scratch qa.d.o and tested HEAD pifr, but forgot I had not committed. :)

@dalin - If you're going to close something, please say why you're closing it.

Ahh, my bad.

And now that I look closer I see that I was getting carried away on this one. The workaround still needs to be removed a la #20.

Patch no longer applies (even with -p0). I'm not sure where this one stands.