I'm getting a warning:
Notice: Undefined property: stdClass::$nodeblock in nodeblock_preprocess_node() (line 194 of /Users/kim/dev/servcorp/pressflow/sites/all/modules/contrib/nodeblock/nodeblock.module).

changing from:

if ($variables['node']->nodeblock) {

to

if (isset($variables['node']->nodeblock)) {

Fixes the problem.
Kim

CommentFileSizeAuthor
#7 nodeblock-972998-6.patch503 bytesbrad.bulger
#1 nodeblock972998.patch937 bytesZardoc

Comments

Zardoc’s picture

Zardoc commented
StatusFileSize
new nodeblock972998.patch937 bytes

Here is a patch containing the above mentioned solution.

frankcarey’s picture

frankcarey commented
Status: Active » Reviewed & tested by the community

Working well in production

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented

Subscribe.

lambic’s picture

lambic commented

+1, patch is good.

aasarava’s picture

aasarava commented

+1, please commit?

brad.bulger’s picture

brad.bulger commented

can we be sure that property is always only set to a TRUE value or not set at all? a value of FALSE, for instance, would pass isset(). if you want to only add the theme file when it's TRUE - seemingly the intent of the original code - !empty() would be better.

brad.bulger’s picture

brad.bulger commented
Version: 6.x-1.4 » 6.x-1.x-dev
StatusFileSize
new nodeblock-972998-6.patch503 bytes

patch for above against current 6.x

Johnny vd Laar’s picture

Johnny vd Laar commented
Status: Reviewed & tested by the community » Fixed

Committed your fix here:http://drupalcode.org/project/nodeblock.git/blobdiff/d066de5ae34ea44e9fe...

Thanks for the help.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.