Comments

fago’s picture

yep, the plan is to port it as soon as the rc is released

Budrick’s picture

OK, it is released.
We all can hardly wait for your module!

sym’s picture

Status: Active » Needs review
StatusFileSize
new2.54 KB

I've ust had a go at updating the module. I've tested it on an install from HEAD (not the RC) and everything seems to work.

I've had to manually include the module in the install file, I'm not sure if that's the correct way of doing it, but I couldn't find any other way.

I'm sure it's not RTBC at all, but it's a starting point. :)

jpetso’s picture

StatusFileSize
new8.61 KB

Here's an extended version of the port - amonst other changes, the module now uses drupal_execute() for creating usernodes and provides uninstall facilities.

fago’s picture

Status: Needs review » Needs work

great - however I've problems applying your patch.
please be sure to create the patch against the latest usernode code (branch 4.7 or HEAD). could you reroll it please?

jpetso’s picture

StatusFileSize
new0 bytes

hm... don't know what could be wrong, but here's a new attempt. plain output of diff -uN.

jpetso’s picture

StatusFileSize
new8.72 KB

Ok, this is evil... one more.

jpetso’s picture

StatusFileSize
new8.36 KB

Now this is really the last time, and now it works. Hah.

jpetso’s picture

StatusFileSize
new8.79 KB

One could call me unprofessional, but in the process of fixing the diff I lost one change.
So here is the final, working, and complete patch. Man...

fago’s picture

Status: Needs work » Active

thanks, great patch. It's fine that creating usernodes through drupal_execute is working.
I've committed it with some minor text changes to cvs HEAD, which will be used for 5.x development now (and branched to 5.x later).

Here are some more ideas to improve usernode 5.x:

* On module activation there is message "Your Usernode has been created.". Probably
this would also appear on registering. let's remove this message.

* with drupal-5 there is normally a new permission for each content-type: edit "content-type" - let's add this for usernode too

* let's do some code-improvements. let's autoload the user object into each usernode through the nodeapi. e.g. let's write the user object into $node->user and adapt is_usernode() & usernode_get_user()

* another code improvement: let's move the nid-saving part in usernode_create_node() to hook_nodeapi

karens’s picture

@fago, I needed this in 5.x so I tried your ported version out. Everything works fine except it is not creating the node titles -- they're all empty. I tried to see if editing a user would force them to update, but that failed, too. I don't know the module well enough to suggest a fix.

I'm using this with my ported version of Location and Location views to display user locations in Views. Except for the titles, it's working great. This module has been surprisingly useful for being able to get user info into Views, so I'd like to do whatever I can to help you get it ported.

fago’s picture

Status: Active » Fixed

it's cool to see that location provides a views integration therefor :)

I've just fixed the node title bug in HEAD, thanks for testing KarenS.
I've also fixed the issue with the messages and created the 5.x branch.

So I'll set this issue as fixed.

Anonymous’s picture

Status: Fixed » Closed (fixed)