Posted by recidive on November 16, 2010 at 7:32am
11 followers
| Project: | Address Field |
| Version: | 7.x-1.x-dev |
| Component: | Address formats |
| Category: | feature request |
| Priority: | major |
| Assigned: | Unassigned |
| Status: | reviewed & tested by the community |
Issue Summary
Here is a patch that adds support for Brazilian Addresses.
| Attachment | Size |
|---|---|
| addressfield-br.patch | 4.83 KB |
Comments
#1
An updated patch, making some more fields required and decreasing size of number field.
#2
I can commit this as is, but I don't really know what it takes to have a full address in Brazil. : D
Just so we have the same understanding on what feels to include / require - are only fields that are actually required to mail something required right now? I'm not use to seeing you have to enter so much, including "neighborhood."
Patch seems to work fine as is, though, and I can commit any time.
#3
Actually, I'm about to do some work to add the name fields in, and I don't wanna royally hose your dev repository. I'm going to commit as is and do my work, but please review based on my last comment. I'm guessing you'll need a follow-up patch to accommodate name information anyways.
#4
There might have better xNAL properties for putting Brazilian address info. I'll check on this when I get the chance.
Moving to needs work.
#5
Hi! I live in Brazil,
and it really needs to have some other fields
I already review the patch and according with this document http://xml.coverpages.org/XNAL-DTDs-display.html the fields are right!
So i can't see why this isn't commited, we really need this stuff :D
Cheers!
#6
This patch needs to be rerolled.
#7
Hi,
Here's a new patch taken today.
Please review.
#8
Rerolling using previous if clause instead of creating a new if clause for the brazilian address .
#9
Here's a reroll from the proper folder. Reverted changes to "Sao Paulo", since it is the proper transliteration. It is wrapped in t() and can be translated to add proper diacritics (to all states).
#10
Is "Neighborhood" really needed? I'm from Brazil too and never sought a website asking me for it.
#11
@pedrorocha, neighborhood is usually asked, and it's important, since there are cities with duplicated street names. It should be translated into "Bairro" in pt-br.
#12
Although "bairro" is a usual information when you think of Brazilian addresses, I seldom see them in web forms. Damn colonialism. Supporting is a good sign, and it serves the purpose of disambiguating duplicated street names.
#13
Sorry, i understood as "referência", but after that i realized it was "Bairro". And obviously, i agree that it should be in every form.
I had a second thought on this case and i think that we could create a specialized module for a brazilian addressfield, because that's why Addressfield module uses CTools plugin system: we can extend it without the need to patch the main module. But i agree that this patch here is a good default and should be commited, without further problems(i'm using it right now).
#14
Any news?
#15
I'd say breaking Brazilian Address stuff to a new module would be interesting, yet it's a matter of a follow up patch.
Let's commit this.
#16
This should happen here #1829900: [meta] Address Field 2.x needs pluggable administrative areas and an actual API
#17
I've been wondering whether 'dependent_locality' (a.k.a. Neighborhood) should go into the
street_blockorlocality_block.It doesn't look right when in locality_block, but I'm not really sure. It does affect the layout of both form and output.
#18
#19
Any news on commiting this!? It's very important for us Brazilians to have these fields on the form :)