Hi,

i'm no drupal export, but it seems a bit strange to disable and enable the modules only using a database query. Shouldn't we use api methods like http://api.drupal.org/api/drupal/includes--module.inc/function/module_di... ? Those methods may additionally call hooks your code doesn't contain.

Thanks for this great module! Its a great addition to further simplify the development process using features.

Georg

Comments

Rob Knight’s picture

Rob Knight commented
Assigned: Unassigned » Rob Knight
Status: Active » Postponed

Agreed. It's really just a proof-of-concept at the moment, but for version 1.0 I'll certainly be doing things in the "right" way. I'll update this soon.

Thanks for showing an interest! :-)

barraponto’s picture

barraponto
he / him
commented

changing the module status on the system table will not only skip the hook_install, hook_enable, hook_disable and hook_uninstall, but it won't even check for dependencies.

as provided, it is actually dangeorous to use this module.