When I'm on a node edit page and click the nodequeue tab, I only see the first queue that the node is available to be put into.

Looks like the problem is in: nodequeue_load_subqueues_by_reference

Specifically:
foreach ($references as $qid => $reference) {
if ($where) {
$where .= ' OR ';
}
$where .= 's.qid = :qid AND s.reference IN (:reference)';
$query->where($where, array(':qid' => $qid, ':reference' => $reference));
}

This SQL is only returning the first queue, not subsequent ones.

CommentFileSizeAuthor
#6 nodequeue_973404.patch1.05 KBScott Reynolds
#2 nodequeue-load-subqueues.patch821 bytesberenddeboer

Comments

berenddeboer’s picture

berenddeboer commented

Same here.

berenddeboer’s picture

berenddeboer commented
Status: Active » Needs review
StatusFileSize
new nodequeue-load-subqueues.patch821 bytes

Here a patch. Not sure how cleanly it applies to the released dev version as I have added more patches.

berenddeboer’s picture

berenddeboer commented
Priority: Normal » Major
kevin p davison’s picture

kevin p davison commented

Still seems to be an issue in 7.x-2.x-dev Dec 27. I can only see one Nodequeue when I have several for this content type.

Status: Needs review » Needs work

The last submitted patch, nodequeue-load-subqueues.patch, failed testing.

Scott Reynolds’s picture

Scott Reynolds commented
Status: Needs work » Needs review
StatusFileSize
new nodequeue_973404.patch1.05 KB

Here is a nicer patch using db_conditions properly

slashrsm’s picture

slashrsm commented
Status: Needs review » Reviewed & tested by the community

Works great for me.

willmoy’s picture

willmoy commented

#6: nodequeue_973404.patch queued for re-testing.

willmoy’s picture

willmoy commented

Confirm RTBC

merlinofchaos’s picture

merlinofchaos commented

There's an extra db_and() in here that's unnecessary:

      $queues->condition(db_and()
        ->condition('s.qid', $qid)
        ->condition('s.reference', $reference, 'IN'));

Should just be

      $queues->condition('s.qid', $qid)->condition('s.reference', $reference, 'IN');
merlinofchaos’s picture

merlinofchaos commented

Ignore #10. I am wrong.

merlinofchaos’s picture

merlinofchaos commented
Status: Reviewed & tested by the community » Fixed

Committed a patch that is substantially the same as Scott's; I wrote it before I found this issue.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.