Table name passed to db_rewrite_sql() not enclosed in brackets

Looking at the query string, "LEFT JOIN default_forum_access fa ON term_data.tid = fa.tid," it would seem that the query alteration being done by forum_access is not respecting the table prefix of "default" that is on all of the tables.

This would seem to be a forum_access issue.

In

forum_access_db_rewrite_sql($query, $primary_table, $primary_field, $args)

we have

      $sql['join'] = "LEFT JOIN {forum_access} fa ON $primary_table.tid = fa.tid
                      LEFT JOIN {acl} acl_fa ON acl_fa.name = $primary_table.tid AND acl_fa.module = 'forum_access'
                      LEFT JOIN {acl_user} aclu_fa ON aclu_fa.acl_id = acl_fa.acl_id AND aclu_fa.uid = $user->uid";

Apparently, someone is passing 'term_data' as $primary_table. How, my dear friend, should FA know that you mean 'default_term_data'? If you look at the documentation of db_rewrite_sql(), you'll see that $primary_table ought to receive the table alias, in this case 'td'...

Thanks for pointing out my error in responding too quickly. Was on the right track but jumped to an incorrect conclusion.

Without brackets, query rewriting by other modules will return an invalid string.

Fixed in 6.x-1.4 release.

You do pass 'td', not '{term_data}', right?

No, I passed the latter value.

As you wrote in #3, the documentation of db_rewrite_sql() indicates the $primary_table can be '{term_data}' instead of the "non-standard" table alias of "td" for this table. Given the non-standard alias, it would seem more reliable for someone writing an hook_db_rewrite_sql() to rely on the table name than its alias. In general, it would not seem a best practice to rely on an arbitrary abbreviation.

Regardless, as your code relies on the primary field (as does node module), is it not a moot point for you? In absence of a survey of all modules with such a hook function, it is not clear which value is being evaluated to trigger a rewrite. Also, as it seems the module triggering this hook has the choice on what value to pass, does it not also seem the responsibility of the hook function writers to consider both values?

You can use whatever alias you want. You're passing in the query and the alias.

If you pass in the table name and one of the hook_db_rewrite_sql() implementations happens to join in the same table again (for whatever reasons), then it'll fail.

Yes, it appears the SQL fails if an aliased table is referenced subsequently by its actual name. So, if you change the db_rewrite_sql() to use 'td' instead of '{term_data} all should be well. Thanks for reporting back.

Corrected in 6.x-1.5 release to use the table alias.