I am using Team Notifications (TN) along with comment_driven.

I just noticed that if I post a comment and don't change any of the "driven" cck fields, I just send 1 message with the content of the comment.

If I change one of the driven cck fields in the comment. It sends one message with the node content, then sends another with the comment content.

I think this is because the node is "being updated" so it sends a message when the node is updated, and one because of the comment.

Also, If I change a driven cck field in the comment and I click the "Do not send notifications for this update." in the TN ui, I still get an email with the node content, but no email with the comment content.

Because of this, I would almost call Team Notifications incompatible with comment driven.. Lots of useless emails are no fun.

CommentFileSizeAuthor
#4 fixextranotification.patch663 bytesthat0n3guy

Comments

that0n3guy’s picture

that0n3guy commented
Project: Driven API » Comment driven

Oops shoulda posted in comment driven I think.

arhak’s picture

arhak commented
Category: bug » support

what you describe is correct, and perfectly understandable

Because of this, I would almost call Team Notifications incompatible with comment driven

I disagree

Lots of useless emails are no fun.

you're right,
something should be done

perhaps it is possible to use the same "Do not send notifications for this update." to make a quiet node update as well (i.e: prevent sending any message, neither comment/node update notifications)

don't know if it might be achievable from cdriven, but certainly TN can always choose to bring better support for cdriven (if it is not solvable from this side only)

that0n3guy’s picture

that0n3guy commented

Wow, thanks for the quick reply. Do you think I should post an issue over in the TN issue queue as well so as to maybe get some insight from them?

Seems like we may some kind of flag that says:

if "node updated" and "from comment", disable node notification.

I haven't looked at the TN code yet, maybe tomorrow or friday, but I can't say if I will get anywhere as I've never messed w/ the code on either of these 2 projects before.

that0n3guy’s picture

that0n3guy commented
Status: Active » Patch (to be ported)
StatusFileSize
new fixextranotification.patch663 bytes

Well that turned out to be a real easy fix.

Attached is a patch, its against alpha3 and not dev (sorry) but its super simple... just adds 2 lines.

Let me know what ya think :).

arhak’s picture

arhak commented
Status: Patch (to be ported) » Needs review

dev and alpha3 aren't so different, so it should apply (perhaps with some offset, but it should work)

one thought:
what if I'm a subscriber who doesn't want to be notified of comments but actually wants to be notified by node updates?
this way a node update will happen without noticing
(or this use case doesn't make sense at all?)

obrienmd’s picture

obrienmd commented

Agreed, I think Arhak's use case (wants to be notified on updates but not comments) does make sense. The solution to this problem probably requires some conditional configuration to work for all common use cases.

arhak’s picture

arhak commented
Status: Needs review » Needs work

The solution to this problem probably requires some conditional configuration

that's what I was thinking

nevertheless, patch @#4 is valid for those wanting to enforce the described behavior

thanks @that0n3guy for pointing it out

that0n3guy’s picture

that0n3guy commented

what if I'm a subscriber who doesn't want to be notified of comments but actually wants to be notified by node updates?

This is a valid use case. But, since notifications don't send any driven info (not even sure it even sends cck info, just the body) this is probably not going to be the case very often. Notifications just get an email w/ the node body (for node updates).

Its pretty confusing for the user because if I change the "type" of a task from Support to Bug... the user gets an email with just the body. Then if I change the status from Open to Resolved, the user gets another email with just the body. So the user gets 2 emails that are exactly the same and don't show any changes.

If notifications would send the driven info (ie... what was changed) then this will defiantly be needed.

obrienmd’s picture

obrienmd commented

Arhak added comment-driven tokens to comments some time ago, thus you can show diffs in notifications (you just have to configure the notification template).

arhak’s picture

arhak commented
Status: Needs work » Needs review

Notifications just get an email w/ the node body (for node updates)

good point

added comment-driven tokens to comments

but they are for comments, he's talking about node update notifications (having comments' notifications disabled)

you just have to configure the notification template

can't I set a node update notification such that fields show up
I wouldn't be able to see how it was changed (i.e: the diff) but I would see how it is now (after being updated)
isn't that the usual node update notification?

PS: switching back to NR, since I would like to heard more discussion about it

obrienmd’s picture

obrienmd commented

Yes, notifications allows use of the usual node tokens for update notification templates - so while you cannot see the diff, you can see the new values for cck fields, node title/path, etc...

that0n3guy’s picture

that0n3guy commented
Issue tags: +cheap ugg

Ahh ha, I didn't know about the tokens... thats pretty cool.

donquixote’s picture

donquixote commented

Patch #4 seems to work.

Now, trying to make the diff show up in the notification:
- Go to admin/messaging/template/edit/notifications-event-node-comment
- Use the [comment-driven-diff-table] token.

I think I am missing something, to make this work as html email with html diff table. So far it's all text-based, and the diff table looks kind of ugly.