Not sure what the 'theme' type in this piece of code supposed to convey, but there is no such type documented for Drupal 7, so it will just fall back to the default:

drupal_add_css($editor['library path'] . '/markitup/skins/' . $theme . '/style.css', 'theme');

The theme type meant a distinct thing in Drupal 6, not anymore in Drupal 7.

CommentFileSizeAuthor
#3 wysiwyg-HEAD.markitup-css.3.patch1.14 KBsun
#2 wysiwyg-HEAD-markitup-css.975546.2.patch843 bytestwod

Comments

twod’s picture

twod
Primary language Swedish
Location Sweden
commented

Looks like something we overlooked when porting to D7, don't remember if that had already changed back then. We've recently gotten a few other issues related to D7 API changes but I've been too busy to look at them yet. :(

twod’s picture

twod
Primary language Swedish
Location Sweden
commented
Title: markitup uses invalid CSS type » MarkItUp still calls drupal_add_css() like in D6
Component: Code » Editor - markItUp
Priority: Minor » Major
Status: Active » Needs review
StatusFileSize
new wysiwyg-HEAD-markitup-css.975546.2.patch843 bytes

D7 API changed since Wysiwyg was ported to it. We'll need to pass an array with a 'group' key with the value CSS_THEME instead. While we're tinkering with this, we might as well go all the way and use the 'basename' key to keep MarkItUp's style.css files from overriding Seven's style.css. That override makes the Seven theme look horrible so I'll bump this to major.

This patch should do the trick.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Fixed
StatusFileSize
new wysiwyg-HEAD.markitup-css.3.patch1.14 KB

Thanks for reporting, reviewing, and testing! Committed to attached patch to HEAD.

A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.