The variable_get defaults for securepages_pages in securepages.admin.inc includes the path 'user', however the variable_get defaults for securepages_pages in securepages.module does not. This will give the impression that the module is not working correctly on the url http://www.example.com/user. Once the user has saved the settings, the variable_get pulls the same value from the database in both places and so becomes consistent.

I have written a small patch to solve this issue. It uses the define() to create constants that hold the default values for securepages_pages and securepages_ignore. These constants are then used for the default values in the variable_get() calls to ensure that there is no difference between what is shown to the user and what is used internally.

Additionally, I have modifed the 'user/*' path to be 'user*' following the patter of 'admin*' This provides protection by default at /user as well as user/login, user/1, etc. with a single config line. Comments are welcome.

CommentFileSizeAuthor
securepages_defines.patch3.07 KBimrook

Comments

grendzy’s picture

Assigned: Unassigned » grendzy
Status: Needs review » Needs work

The next release will use constants for the default settings, to match the 7.x branch.

grendzy’s picture

Status: Needs work » Fixed
grendzy’s picture

Version: 6.x-1.x-dev » 6.x-2.x-dev

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.