Needs review
Project:
TinyBrowser
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
19 Nov 2010 at 00:40 UTC
Updated:
19 Nov 2010 at 15:18 UTC
Hello all,
I've found a conflict with Brilliant Gallery module - the window of TinyBrowser appears to be blank. It is because of bad function name resizeimage. This function name also appears in Brilliant Gallery module, so the conflict causes PHP error.
I've fixed this issue by renaming the function to tinybrowser_resizeimage. I'd like to make a patch, but I'm not friendly with patch system, so I apologize.
Also I recommend (another minor issue) adding a line with globals declaration to debug functions, which otherwise will not work.
(I'm sorry for my poor English)
Comments
Comment #1
pixture commented> @ricco
While working on porting this module to D7, I have noticed that 'show_debug_info()' has to have the global declaration. :-)
And I agree that I should use tinybrowser_ or tb_ prefix to all PHP function this module uses to avoid possible conflict in PHP function names. Since I am working on D7 version now, I will change function names for D7 version now, and then do it for D6 later on.
Thanks for your information. !!!