UI fails without 'access callback' defined [PATCH]

indeed, that one is required. Fixed the docs to mention that.

thanks, committed.

You'll need to use git diff --no-prefix for creating patches for d.o.

I believe there is also an inconsistency at play here in the implementation of the propertyAccess function in entity.wrapper.inc. At least with respect to how the other Entity API's access functions such as entityAccess and entity_access work. Those functions return NULL if an 'Access Callback' has not been set. This makes sense because then the caller can decide if NULL should be treated TRUE or FALSE in terms of granting access. However, propertyAccess assumes FALSE if its call to entityAccess returns NULL where it should probably just forward the result onward.

This affects rules access checking for certain entity related actions and in my case is preventing me from being able to use a VBO operation based on a rules component that uses the 'set data value' on an entity that does not specify an 'access callback'. I'm referencing the issue I've opened for rules here as well: #1526198: Default to TRUE if entity_access returns 'NULL'

Here is a patch to set it straight.

Patch applies nicely. The logic's pretty simple. Ran it through Coder and there were no problems reported on the patch that was contributed.

Defaulting to NULL for propertAccess() if no entity access is defined makes sense to me. We should document it though why we are passing through $access + state this at docs of the access() method.

I would be happy to update the documentation when this get committed.

@fago so that patch needs to be rebuilt to change the defaults for propertAccess().

@fago: Originally I thought you meant add to the documentation of the module, but looking back at your comment in #9 I realize you probably meant document the propertyAccess() function to explain in-line why we would pass $access through. So I have gone ahead and rebased against the latest dev and added some description to the function.

Does this work for you?

The 6 year old patch in #12 to entity.wrapper.inc does not apply to the latest entity 7.x-1.x-dev.

entity-forward-entityAcces-in-propertyAccess-976360-9.patch:20: trailing whitespace.
   * 
Checking patch includes/entity.wrapper.inc...
error: while searching for:
    }
  }

  protected function propertyAccess($name, $op, $account = NULL) {
    $info = $this->getPropertyInfo($name);
    // If the property should be accessed and it's an entity, make sure the user
    // is allowed to view that entity.
    if ($op == 'view' && $this->$name instanceof EntityDrupalWrapper && !$this->$name->entityAccess($op, $account)) {
      return FALSE;
    }
    // If a property should be edited and this is an entity, make sure the user
    // has update access for this entity.

error: patch failed: includes/entity.wrapper.inc:498
error: includes/entity.wrapper.inc: patch does not apply

@Chris Matthews, Here's the patch for the same, kindly share your feedback after using it. Thanks!.