includes/common.inc valid_email_address() allows mails to have a tailing dot

CommentFileSizeAuthor
#17 no_pref_another.patch568 bytesdpovshed
#16 no_pref_another_d6.patch568 bytesdpovshed
#12 noprefix.patch568 bytesdpovshed
#8 now_with_git.patch449 bytesdpovshed
#6 valid_email_fix_by_cvs.patch750 bytesdpovshed
#2 valid_email_address_fix.patch537 bytesdpovshed

Comments

Anonymous’s picture

Anonymous (not verified) commented

Drupal 6 valid_email_address() allows mail to have a tailing dot.
valid_email_address('salimane@gmail.com.') => true

dpovshed’s picture

dpovshed commented
StatusFileSize
new valid_email_address_fix.patch537 bytes

Thanks Salimane,

pretty rare user misprint, but here is a patch for this attached.

Regards, Dennis

dpovshed’s picture

dpovshed commented
Priority: Normal » Minor
Status: Active » Needs review

patch is ready to review

Status: Needs review » Needs work

The last submitted patch, valid_email_address_fix.patch, failed testing.

Anonymous’s picture

Anonymous (not verified) commented

The patch is not in the correct format.

dpovshed’s picture

dpovshed commented
Status: Needs work » Needs review
StatusFileSize
new valid_email_fix_by_cvs.patch750 bytes

regenerated with CVS...

Status: Needs review » Needs work

The last submitted patch, valid_email_fix_by_cvs.patch, failed testing.

dpovshed’s picture

dpovshed commented
Status: Needs work » Needs review
StatusFileSize
new now_with_git.patch449 bytes

here goes mr git...

Status: Needs review » Needs work

The last submitted patch, now_with_git.patch, failed testing.

ygerasimov’s picture

ygerasimov commented 
diff --git includes/common.inc includes/common.inc
index 84558ea..80c3a86 100644

Please remove the git headers from patch.

Powered by Dreditor.

dpovshed’s picture

dpovshed commented
Status: Needs work » Needs review

Dear Yuriy, here http://drupal.org/node/947616 in comment #15 test has been approved with such stuff. :/

dpovshed’s picture

dpovshed commented
StatusFileSize
new noprefix.patch568 bytes

git with noprefix

Anonymous’s picture

Anonymous (not verified) commented

As this issue is marked for Drupal 6, mark the patch for Drupal 6, or the test bot will try to apply it for Drupal 6.

Status: Needs review » Needs work

The last submitted patch, noprefix.patch, failed testing.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs work » Needs review

The error message is the following one:

Command [patch -p0 -i /var/lib/drupaltestbot/sites/default/files/review/noprefix.patch 2>&1] failed with status [1] and output:
can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git includes/common.inc includes/common.inc
|index 84558ea..80c3a86 100644
|--- includes/common.inc
|+++ includes/common.inc
--------------------------
dpovshed’s picture

dpovshed commented
StatusFileSize
new no_pref_another_d6.patch568 bytes

Thanks kiam for trying to help!

maybe this one is related? http://drupal.org/node/961172

Anyway, lets try with -d6 suffix...

dpovshed’s picture

dpovshed commented
StatusFileSize
new no_pref_another.patch568 bytes

previous one was just ignored, it is D6 already by default

Status: Needs review » Needs work

The last submitted patch, no_pref_another.patch, failed testing.

ygerasimov’s picture

ygerasimov commented
Status: Needs work » Needs review

#17: no_pref_another.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, no_pref_another.patch, failed testing.

dpovshed’s picture

dpovshed commented

Dear Yuriy, thanks for help! The patch is correct, there are troubles with QA server. See comments #25, #26
http://drupal.org/node/961172#comment-3754802

dpovshed’s picture

dpovshed commented
Status: Needs work » Needs review

#17: no_pref_another.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, no_pref_another.patch, failed testing.

dpovshed’s picture

dpovshed commented
Status: Needs work » Needs review

#17: no_pref_another.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, no_pref_another.patch, failed testing.

FreekyMage’s picture

FreekyMage commented

In 6.19 the address "address@x." is also considered a valid emailaddress. Can anyone confirm that this is also the case in the dev version? Not sure if this is the same problem since my regex skills are really bad.

dpovshed’s picture

dpovshed commented
Status: Needs work » Needs review

#17: no_pref_another.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, no_pref_another.patch, failed testing.

dpovshed’s picture

dpovshed commented
Status: Needs work » Needs review

#2: valid_email_address_fix.patch queued for re-testing.

dpovshed’s picture

dpovshed commented

Guys,

here was a problem with testing server not with the patch.

Now first patch successfully passed testing - see comment #2. The fixed issue is not exists in Drupal 7 or Drupal 8, can someone just reconfirm here that patch is OK and tested by community.

Thanks!
Dennis

Status: Needs review » Closed (outdated)

Automatically closed because Drupal 6 is no longer supported. If the issue verifiably applies to later versions, please reopen with details and update the version.