After applying the patch in #976598: Media settings redirect to Structure the settings are displayed, the Manage Fields/Display tabs show correct (after clearing the cache) but the Settings only give me these two warning:

    * Notice: Trying to get property of non-object in media_admin_type_manage_form() (line 339 of [path]\sites\all\modules\media\media.admin.inc).
    * Notice: Trying to get property of non-object in media_admin_type_manage_form() (line 344 of [path]\sites\all\modules\media\media.admin.inc).

This is with Drupal 7 beta 3.

CommentFileSizeAuthor
#9 media.module.patch755 bytesmcaden
#8 media.module.patch772 bytesmcaden

Comments

JacobSingh’s picture

JacobSingh commented

clear your cache.

tsvenson’s picture

tsvenson commented

As I wrote, I did that. These warnings are after clearing the cache. Just tried it again with the same notices showing up. Only the notices are showing, there are no settings available in that tab. The other two works just fine.

JacobSingh’s picture

JacobSingh commented

Oh sorry, I should have read that. Media is not working on BETA-3 yet. See the project page for how we're doing versions. IF it's still a bug in BETA-2, let's look at it, if not, let's still look at it but I have no knowledge of the state of BETA-3 other than that it is broken.

-J

tsvenson’s picture

tsvenson commented

I'm aware of the note about which version of Drupal use. I will retest this with beta to in a bit and report back if its a problem there as well.

tsvenson’s picture

tsvenson commented
Priority: Normal » Critical

@Jacob

Just tried this with Drupal 7 beta 2 and got the exact same error messages on a fresh installation.

Upping this to critical since Settings is unavailable.

cfuller12’s picture

cfuller12 commented

Looks like this is just a simple matter of the wrong URL argument being passed to the page callback. In other words, in media_menu

    'title arguments' => array(5),
    'description' => 'Manage files used on your site.',
    'page callback' => 'drupal_get_form',
    'page arguments' => array('media_admin_type_manage_form', 4),

should be 

    'title arguments' => array(5),
    'description' => 'Manage files used on your site.',
    'page callback' => 'drupal_get_form',
    'page arguments' => array('media_admin_type_manage_form', 5),

The title argument was changed in patch #976598: Media settings redirect to Structure but the page argument wasn't.

tsvenson’s picture

tsvenson commented

@cfuller

Yes, that sorted it. Thanks. Settings are back.

FYI, it is line 76 in the media.module file that needs to be changed.

mcaden’s picture

mcaden commented
Status: Active » Needs review
StatusFileSize
new media.module.patch772 bytes

Patched against head. Fixes it for D7 beta 3.

mcaden’s picture

mcaden commented
StatusFileSize
new media.module.patch755 bytes

I think I've been screwing up the line-endings on my patches so it's rejecting them, trying again.

Status: Needs review » Needs work

The last submitted patch, media.module.patch, failed testing.

tsvenson’s picture

tsvenson commented

It might be failing because it needs the patch in #976598: Media settings redirect to Structure.

mcaden’s picture

mcaden commented

I did an update. I have the latest revision at HEAD.

EDIT: Just checked, the patch you mentioned was applied to HEAD before I updated so it's already in.

mcaden’s picture

mcaden commented
Status: Needs work » Needs review

#9: media.module.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, media.module.patch, failed testing.

JacobSingh’s picture

JacobSingh commented
Status: Needs work » Fixed

Committed! Thanks
http://drupal.org/cvs?commit=454390

mcaden’s picture

mcaden commented

Awesome, incidentally - any tips on why my patches fail testing?

JacobSingh’s picture

JacobSingh commented

Not sure... it looks okay

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.