Posted by tsvenson on November 19, 2010 at 4:02pm
5 followers
| Project: | Media |
| Version: | 7.x-1.0-beta2 |
| Component: | User interface |
| Category: | bug report |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
After applying the patch in #976598: Media settings redirect to Structure the settings are displayed, the Manage Fields/Display tabs show correct (after clearing the cache) but the Settings only give me these two warning:
* Notice: Trying to get property of non-object in media_admin_type_manage_form() (line 339 of [path]\sites\all\modules\media\media.admin.inc).
* Notice: Trying to get property of non-object in media_admin_type_manage_form() (line 344 of [path]\sites\all\modules\media\media.admin.inc).This is with Drupal 7 beta 3.
Comments
#1
clear your cache.
#2
As I wrote, I did that. These warnings are after clearing the cache. Just tried it again with the same notices showing up. Only the notices are showing, there are no settings available in that tab. The other two works just fine.
#3
Oh sorry, I should have read that. Media is not working on BETA-3 yet. See the project page for how we're doing versions. IF it's still a bug in BETA-2, let's look at it, if not, let's still look at it but I have no knowledge of the state of BETA-3 other than that it is broken.
-J
#4
I'm aware of the note about which version of Drupal use. I will retest this with beta to in a bit and report back if its a problem there as well.
#5
@Jacob
Just tried this with Drupal 7 beta 2 and got the exact same error messages on a fresh installation.
Upping this to critical since Settings is unavailable.
#6
Looks like this is just a simple matter of the wrong URL argument being passed to the page callback. In other words, in media_menu
'title arguments' => array(5),'description' => 'Manage files used on your site.',
'page callback' => 'drupal_get_form',
'page arguments' => array('media_admin_type_manage_form', 4),
should be
'title arguments' => array(5),'description' => 'Manage files used on your site.',
'page callback' => 'drupal_get_form',
'page arguments' => array('media_admin_type_manage_form', 5),
The title argument was changed in patch #976598: Media settings redirect to Structure but the page argument wasn't.
#7
@cfuller
Yes, that sorted it. Thanks. Settings are back.
FYI, it is line 76 in the media.module file that needs to be changed.
#8
Patched against head. Fixes it for D7 beta 3.
#9
I think I've been screwing up the line-endings on my patches so it's rejecting them, trying again.
#10
The last submitted patch, media.module.patch, failed testing.
#11
It might be failing because it needs the patch in #976598: Media settings redirect to Structure.
#12
I did an update. I have the latest revision at HEAD.
EDIT: Just checked, the patch you mentioned was applied to HEAD before I updated so it's already in.
#13
#9: media.module.patch queued for re-testing.
#14
The last submitted patch, media.module.patch, failed testing.
#15
Committed! Thanks
http://drupal.org/cvs?commit=454390
#16
Awesome, incidentally - any tips on why my patches fail testing?
#17
Not sure... it looks okay
#18
Automatically closed -- issue fixed for 2 weeks with no activity.