Closed (won't fix)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
19 Nov 2010 at 16:10 UTC
Updated:
16 Jun 2011 at 11:41 UTC
Jump to comment: Most recent file
Comments
Comment #1
Architeck commentedAttaching the module.
Comment #2
avpadernoHello, and thank you for applying for a CVS account.
As per requirements, the motivation should include a description of the module features (more than two sentences), and a comparison with the existing solutions.
Comment #3
Architeck commentedModule Features:
The module allows for fast and flexible method to embed a Vanilla Forum into a Drupal website. The module provides a very simple interface which allows for the user to paste in the forum embed code provided by Vanilla and specify a path to access the embedded forum. Additionally access controls are available to restrict access to the embedded forum path. The module also creates a block which can be used to embed the forum using the block/region assignment method.
Compared to existing solutions:
Currently no existing modules allow for Vanilla Forums integration with Drupal. The purpose of this module is not to take the place of any Drupal forum oriented modules but rather to provide a very simple wrapper for new and existing Vanilla Forum/Drupal users to use the embed code provided by Vanilla and access the Vanilla Forum within a Drupal environment.
Comment #4
Architeck commentedUpdated with module Features and comparison.
Comment #5
avpadernoHello, and thank you for your reply.
What is the difference between Vanilla Forums, and the forums provided by Drupal?
Comment #6
michelleI've looked at Vanilla in the past and it's fairly different. It could be replicated with Advanced Forum but would take a bit of work. I've seen others asking for Vanilla integration in the past so, as much as I hate to say it, I think it would be a worthwhile contribution. :)
Michelle
Comment #7
Architeck commentedAdding some references to community requests for this functionality.
http://drupal.org/node/#93309
http://drupal.org/node/#915386
http://tinyurl.com/3xz79ff
Comment #8
Navvywavvy commentedI am the founder of Vanilla Forums, and I can provide any information necessary. Vanilla is an open-source (GPL v2) forum platform that powers discussions on over 400,000 sites around the world. Vanilla is a PHP-based modern take on discussion forums with a focus on customization and inter-operability. We make it very easy to add a modern community discussion piece to your existing site, and we are putting a heavy focus on making nice integrations for other popular platforms like Drupal as we've had many drupal users coming to our site asking for help getting Vanilla integrated.
You can find out more about our project at http://vanillaforums.org, review over 500 addons for Vanilla in our addon repository at http://vanillaforums.org/docs. I'll keep watching this discussion and answer any questions you have.
Comment #9
lolandese commentedSubscribe
Comment #10
jaxxed commentedReviewed and used
Comment #11
bfroehle commentedA cursory look at the code shows that it could certainly benefit from some cleanup -- specifically the coding standards related to indentation would make the code a lot easier to read.
Edit: a good way to get your code cleaned up is to run it through the coder module.
Comment #12
jaxxed commentedI'll take a look
Comment #13
arianek commentedHi. Please read all the following and the links provided as this is very important information about your CVS Application:
Drupal.org has moved from CVS to Git! This is a very significant change for the Drupal community and for your application. Please read the following documentation on how this affects and benefits you and the application process:
Migrating from CVS Applications to (Git) Full Project Applications
Comment #14
Architeck commentedI have created a sandbox project at http://drupal.org/sandbox/Architeck/1084626
I also ran the module through the coder module as suggested before committing the initial code.
Please review and contribute to the sandbox project and I will transition the sandbox code to a full project application when the code is good and ready.
Thanks!
Comment #15
bluegray commentedThere is a module for vanilla ProxyConnect SSO here as well in case anybody is interested:
http://drupal.org/project/orchid
Comment #16
Architeck commentedhttp://drupal.org/sandbox/Architeck/1084626
Comment #17
muldos commentedHi there !
I just found this topic, and I am the maintainer of the orchid module which has the same goal (provide ease to embed vanilla into drupal) and also provides SSO with the ProxyConnect module.
Currently the module provide a block and a panel pane to ease embedding a vanilla forum.
It is available for 6.x and 7.x
I would be glad to share the orchid maintenance and evolution with you Architeck because I found that Drupal and Vanilla can be a killer combo to quickly build a community oriented website :)
Here is the roadmap I expect to have a really great integration :
- providing avatar synchro between drupal and vanilla
- providing a Drupal Embed Theme (which remove for example sign in and sign out link and do a bit of cleaning on a user profile page)
- Providing a really better documentation
- more security with default drupal permission system
Just let me know if you are interested :)
David
module page : http://drupal.org/project/orchid
screencast : http://vimeo.com/muldos/orchid
Comment #18
tim.plunkettComment #19
sreynen commentedLooks like Architeck needs to respond to the co-maintainer offer from muldos before this is reviewed (or closed).
Comment #20
Architeck commentedRegarding the orchid co-maintainer-ship offer,
I appreciate the offer to co-maintain your module. If you need help to manage it moving forward I can help you out as a co-maintainer. Please see my comments below to understand my intentions with the embed vanilla module.
Why should the embed vanilla module live on it's own?
The embed vanilla module was written to mimic the functionality of the embed vanilla wordpress module. I was asked by the vanilla team to produce a Drupal version of the same, very simple, bare bones utility for embedding a Vanilla forum into Drupal.
As some users will be seeking only the embed functionality, I believe that this module can co-exist with the orchid module. I would be more than happy to link to the orchid module in the project page description to help guide users who are looking for functionality beyond the basic embedding feature of the embed vanilla module.
Comment #21
jaxxed commentedI've made two commits (sorry for the poor commit messages)
1. I've removed an old file that was no longer needed,
2. I've reformatted the code to be inline with drupal standards, made 1 or two structural messages, and made some suggestions
Arch: I'll send you a message detailing the suggestions
Comment #22
vimalramaka commentedEmbedding: Works like a charm!
User integration: Doesn't
Is this module supposed to integrate the users too? Or else what is the point of having it? If it doesn't integrate the users, we can just get the embed script from the Vanilla Forum and paste it into any node.
Comment #23
muldos commentedHi there again !
I add some details about orchid : the embed and the sso part are totally independant, you dont' ahave to use sso to embed vanilla in a drupal website with orchid.
I just lack of time to do better screencast for the moment but a screencast that will show only the embed part would be a 2mn /3mn screencast, so I believe a setup that long is pretty acceptable for every user ;)
Anyway I will respect your decision Architeck, if you think that the fact than orchid also provide sso with proxyconnect could be a problem for some users !
The embed part in my (too long and too french :p) screencast start at 21:26 and it's cleaner with panels than with standard blocks, I found.
http://vimeo.com/22023735
Maybe "Navywavy" could give us his feeling about if we should merge or keep two modules, because proxyconnect is also made by vanilla team and I was planning to integrate other block and panels pane for the new embeddable Widgets soon in orchid.
David
Comment #24
sreynen commentedComment #25
sreynen commentedI avoided getting involved in this for a while, because I wasn't sure how to deal with it, but it's been sitting here too long, so I'm going to jump in now.
I looked through the code of both embedvanilla and orchid, and I don't see any functionality in embedvanilla that isn't already included in orchid. If you look at the bottom of #539608: What to expect from the review process, you'll see that "I have written a much simpler version" is explicitly listed as a commonly rejected motivation for creating a new module. Drupal.org heavily favors collaboration on a single project over multiple projects with overlapping functionality. It's one of our core principles.
As much as I hate to reject an application that has been waiting so long, I can't see how embedvanilla can be justified as a new full project. Architeck, if you have any other Drupal projects, please consider creating a new application. If you contact me, I will review it much more quickly this time. My opinion is this shouldn't go forward, and you should instead accept muldos' offer to make you a co-maintainer on the orchid project.
If you would like to get a second opinion, just set it back to "needs review" and I'll ask someone else from the Code Review group to look at this. If you're not interested in pursuing this application further, please set the status to "closed (won't fix)".
Comment #26
Architeck commentedsreynen I appreciate your take on all of this. I will certainly take you up on the offer to review my next contribution/application.
I originally wrote the module to get my feet wet contributing code to the community and to help the guys over at Vanilla come up with a Drupal version of the embed vanilla plugin.
I understand the need to eliminate duplicate projects and focus/collaborate our efforts on developing well written, documented and supported modules.
muldos, let me know if you need help to maintain, extend or test your orchid module.
Anyone looking for Vanilla Forums integration with Drupal should head over to the orchid project page - http://drupal.org/project/orchid
Thanks for everyone's feedback and contribution, this application is now closed.
Comment #27
muldos commentedYour welcome aboard Architeck !