Needs work
Project:
Iso 639
Version:
6.x-1.0-beta1
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
19 Nov 2010 at 16:21 UTC
Updated:
13 Apr 2011 at 12:10 UTC
This module simply does not work. I'm providing a patch attached to this issue that makes it work and simplifies it.
| Comment | File | Size | Author |
|---|---|---|---|
| iso_639.patch | 7.35 KB | guillaumev |
Comments
Comment #1
omissis commentedI' m going to take a look at the patch as soon as I can. For the moment, thanks for the effort.
Comment #2
johnvGreat module! I tested the patch for D6-20, which works fine.
I have the following remarks:
- Description can be more in line with other CCK-contribs: description = Defines a language field type, defined by ISO 639.
- for the list of allowed languages, you could reference with drupal/includes/locale.inc. This reduces maintenance.
- I wonder is the current 2-character field gives any problems when (creating a view) joining this field with the user/node-language, which is a varchar(12)-field (see tables node and user). You might consider the longer field. Also, for some languages, no char2-value exists.
- The following should I post as a separate issue: I tried porting the patch to Drupal 7, but did not succeed. Is it in your plans?
Comment #3
omissis commentedHi, thanks for reviewing the patch, since I haven't had time to do it myself yet. Theoretically yes, I' d like to port the module to D7, even though I fear the patch breaks the functionalities this module was meant to provide to the epub module(that' s why guillaumev says that "This module simply does not work"). So I should take some time to integrate what guillaumev has done and what is needed for the epub module, and then port it to D7.
Thanks for your suggestions anyway, I'm going to check what you say asap.
Comment #4
johnvcategorizing.
Comment #5
johnvComment #6
omissis commentedComment #7
omissis commentedHi, I've finally integrated the patch on the master branch, so that now it has both the fapi field (as required by epub module) and the cck field/widget (as expected by an admin user). I am not rolling out a new release for the moment b/c I also want to check other issues first. If anyone has comments though, they'll be appreciated.
Comment #8
omissis commentedComment #9
omissis commentedAfter I slept on it I changed my mind and removed the FAPI element part and left just the cck field, modifying the epub module accordingly.
Comment #10
johnvOK, have you made a decision on using a length of Char2 or Char12 for the length, as I mentioned in #2, for allowing nl-BE and fr-BE, etc.?
Comment #11
omissis commentedHi, I will keep the field 2 char long for a number of reasons: first of all this module was born for implementing a select list for ISO 639-1 codes, as required by the epub library I use for the epub module. It eventually became a cck field/widget couple in the last few days. The codes you're looking for are part of the IETF language code specification, defined by RFC 1766, 3066, 4646 and 4647 and are using ISO 639 for the language part. Therefore it might make sense to implement a separated module for that, called, say, IETF Language tag.
Comment #13
johnvI understand your point.
Can we find this version on the project page, too? It now only states the aug-2010 version.
Comment #14
omissis commentedI have rolled a dev release, it should appear in minutes. You can also check on the git repo though.
Comment #15
johnvomissis, can you publish the -dev on the project page and close this issue afterwards? Thanks.
Comment #16
omissis commentedYou can find the dev release here: http://drupal.org/node/887004/release